Bug 505972 - AIRD files are not binary files
Summary: AIRD files are not binary files
Status: NEW
Alias: None
Product: Sirius
Classification: Modeling
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows NT
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2016-10-14 07:54 EDT by Ed Willink CLA
Modified: 2016-11-09 09:53 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Willink CLA 2016-10-14 07:54:01 EDT
The org.eclipse.team.core.filetypes declaration for *.aird seems to be missing so that *.aird are treated as binary files. e.g File->Convert Line Delimiters to Unix ignores them.
Comment 1 Laurent Fasani CLA 2016-10-17 08:57:18 EDT
We have no reason to declare aird file as binary file. 	On the contrary, we have reason to keep the ability to do some textual comparison between two aird.

But I guess, you have an underlying problem that you may tell more about it.(or not ;) if you consider,after all, that there is nothing to see with Sirius )
Comment 2 Ed Willink CLA 2016-10-17 10:31:20 EDT
The Eclipse default is that files are binary, so it is necessary to have an org.eclipse.team.core.filetypes for every non-binary file type. Please add one for *.aird.
Comment 3 Laurent Fasani CLA 2016-10-18 09:15:24 EDT
Ok, we agree that it would be an interesting improvement.
It's not yet in the scope of a release but I'm marking it so that we consider it for inclusion in the next release.
Comment 4 Ed Willink CLA 2016-10-18 09:43:38 EDT
(In reply to Laurent Fasani from comment #3)
> Ok, we agree that it would be an interesting improvement.

Since the files fail to observe normal Eclipse behaviour it is a bug not an enhancement.

> It's not yet in the scope of a release but I'm marking it so that we
> consider it for inclusion in the next release.

All that is required is a plugin.xml declaration such as

   <extension point="org.eclipse.team.core.fileTypes">
      <fileTypes extension="aird" type="text" />
   </extension>
Comment 5 Cedric Brun CLA 2016-11-09 05:12:53 EST
This discussion on the egit mailling list might be relevant:

https://dev.eclipse.org/mhonarc/lists/egit-dev/msg04215.html
Comment 6 Ed Willink CLA 2016-11-09 09:53:49 EST
(In reply to Cedric Brun from comment #5)
> This discussion on the egit mailling list might be relevant:

Not really. That is about making EGIT 'smart'. IMHO any attempt to get a CM tool to distort file content predictably is a recipe for endless obscure excitements. Let all files be 'binary'. i.e. use Unix new-lines on all platforms.