Description Andrey Loskutov 2016-10-10 03:55:44 EDT

During investigations for bug 504058 I found that the current implementation of JDTIgnoreRecommendations doesn't make sense anymore, since org.eclipse.team.svn.core.utility.SVNUtility.isIgnored(IResource) already checks the derived flag on resources.

After checking for resource.isDerived(IResource.CHECK_ANCESTORS) SVNUtility.isIgnored asks repeatably

if (ignore.isAcceptableNature(resource) && ignore.isIgnoreRecommended(resource))

which *both* cause an *extra* overhead by going deep into JDT/platform resources  code, cloning project descriptons, project natures, looping over (potentially multiple) natures, creatung JavaProject's, calling into JDT synchronized blocks (which can cause deadlocks, as seen in bug 359199), even forcing classpath resolving in worst case.

This all is not needed at all, because all JDT generated resources has properly set their "derived" attribute.

So the best way to fix it is to entirely remove the org.eclipse.team.svn.resource.ignore.rules.jdt bundle from the code/distribution. 

The users of this bundle should be warned that they only get performance overhead and probably extra deadlocks, and the bundle should be removed from the Subversive update sites.