Community
Participate
Working Groups
Created attachment 264544 [details] reproducer model Fail to create nattable property editor with following exception. Steps to reproduce. 1. Create a new workspace. This is important since we cannot reproduce with existing workspace. 2. Make sure you have Papyrus-RT installed if you are going to use reproducer. 3. Open model and select protocol/message1 throws exception and unable to use table. java.lang.IllegalStateException: Cannot modify resource set without a write transaction at org.eclipse.emf.transaction.impl.TransactionChangeRecorder.assertWriting(TransactionChangeRecorder.java:348) at org.eclipse.emf.transaction.impl.TransactionChangeRecorder.appendNotification(TransactionChangeRecorder.java:302) at org.eclipse.papyrus.infra.emf.readonly.PapyrusROTransactionalEditingDomain$1.appendNotification(PapyrusROTransactionalEditingDomain.java:105) at org.eclipse.emf.transaction.impl.TransactionChangeRecorder.processResourceNotification(TransactionChangeRecorder.java:272) at org.eclipse.emf.transaction.impl.TransactionChangeRecorder.notifyChanged(TransactionChangeRecorder.java:238) at org.eclipse.emf.common.notify.impl.BasicNotifierImpl.eNotify(BasicNotifierImpl.java:374) at org.eclipse.emf.common.notify.impl.NotifyingListImpl.dispatchNotification(NotifyingListImpl.java:261) at org.eclipse.emf.common.notify.impl.NotifyingListImpl.addUnique(NotifyingListImpl.java:294) at org.eclipse.emf.common.util.AbstractEList.add(AbstractEList.java:303) at org.eclipse.papyrus.uml.properties.widgets.NattablePropertyEditor$3.doExecute(NattablePropertyEditor.java:1144) at org.eclipse.emf.transaction.RecordingCommand.execute(RecordingCommand.java:135) at org.eclipse.emf.common.command.CompoundCommand.execute(CompoundCommand.java:261) at org.eclipse.papyrus.uml.properties.widgets.NattablePropertyEditor.createTableWidget(NattablePropertyEditor.java:412) at org.eclipse.papyrus.uml.properties.widgets.NattablePropertyEditor.createWidgets(NattablePropertyEditor.java:330) at org.eclipse.papyrus.uml.properties.widgets.NattablePropertyEditor.doBinding(NattablePropertyEditor.java:314) at org.eclipse.papyrus.infra.properties.ui.widgets.AbstractPropertyEditor.checkInput(AbstractPropertyEditor.java:181) at org.eclipse.papyrus.uml.properties.widgets.NattablePropertyEditor.checkInput(NattablePropertyEditor.java:261) at org.eclipse.papyrus.uml.properties.widgets.NattablePropertyEditor.setTableConfigurationURI(NattablePropertyEditor.java:216) at org.eclipse.papyrus.uml.properties.widgets.NattablePropertyEditor.setTableURI(NattablePropertyEditor.java:240) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at org.eclipse.xwt.javabean.metadata.properties.BeanProperty.setValue(BeanProperty.java:91) at org.eclipse.xwt.javabean.ResourceLoader.initSegmentAttribute(ResourceLoader.java:1849) at org.eclipse.xwt.javabean.ResourceLoader.initAttribute(ResourceLoader.java:1594) at org.eclipse.xwt.javabean.ResourceLoader.init(ResourceLoader.java:1194) at org.eclipse.xwt.javabean.ResourceLoader.doCreate(ResourceLoader.java:681) at org.eclipse.xwt.javabean.ResourceLoader.doCreate(ResourceLoader.java:717) at org.eclipse.xwt.javabean.ResourceLoader.doCreate(ResourceLoader.java:717) at org.eclipse.xwt.javabean.ResourceLoader.createUIElement(ResourceLoader.java:378) at org.eclipse.xwt.internal.core.Core.createCLRElement(Core.java:630) at org.eclipse.xwt.internal.core.Core.load(Core.java:772) at org.eclipse.xwt.internal.core.Core.load(Core.java:660) at org.eclipse.xwt.XWTLoader.loadWithOptions(XWTLoader.java:1072) at org.eclipse.xwt.XWT.loadWithOptions(XWT.java:623) at org.eclipse.papyrus.infra.properties.ui.runtime.DefaultDisplayEngine.createSection(DefaultDisplayEngine.java:314) at org.eclipse.papyrus.infra.properties.ui.runtime.DefaultDisplayEngine.createSection(DefaultDisplayEngine.java:217) at org.eclipse.papyrus.infra.properties.ui.xwt.XWTSection.display(XWTSection.java:160) at org.eclipse.papyrus.infra.properties.ui.xwt.XWTSection.refresh(XWTSection.java:171) at org.eclipse.ui.views.properties.tabbed.TabContents$6.run(TabContents.java:217) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42) at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:50) at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:173) at org.eclipse.ui.views.properties.tabbed.TabContents.refresh(TabContents.java:220) at org.eclipse.ui.views.properties.tabbed.TabbedPropertySheetPage$SelectionChangedListener.selectionChanged(TabbedPropertySheetPage.java:221) at org.eclipse.jface.viewers.Viewer$1.run(Viewer.java:158) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42) at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:50) at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:173) at org.eclipse.jface.viewers.Viewer.fireSelectionChanged(Viewer.java:155) at org.eclipse.jface.viewers.StructuredViewer.updateSelection(StructuredViewer.java:2191) at org.eclipse.jface.viewers.StructuredViewer.handleSelect(StructuredViewer.java:1229) at org.eclipse.jface.viewers.StructuredViewer$4.widgetSelected(StructuredViewer.java:1258) at org.eclipse.jface.util.OpenStrategy.fireSelectionEvent(OpenStrategy.java:242) at org.eclipse.jface.util.OpenStrategy.access$4(OpenStrategy.java:236) at org.eclipse.jface.util.OpenStrategy$1.handleEvent(OpenStrategy.java:405) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4410) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1079) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1103) at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1088) at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:802) at org.eclipse.ui.internal.views.properties.tabbed.view.TabbedPropertyList.select(TabbedPropertyList.java:864) at org.eclipse.ui.internal.views.properties.tabbed.view.TabbedPropertyViewer.setSelectionToWidget(TabbedPropertyViewer.java:122) at org.eclipse.jface.viewers.StructuredViewer.setSelectionToWidget(StructuredViewer.java:1770) at org.eclipse.jface.viewers.StructuredViewer.setSelection(StructuredViewer.java:1726) at org.eclipse.jface.viewers.Viewer.setSelection(Viewer.java:383) at org.eclipse.ui.views.properties.tabbed.TabbedPropertySheetPage.setInput(TabbedPropertySheetPage.java:747) at org.eclipse.ui.views.properties.tabbed.TabbedPropertySheetPage.selectionChanged(TabbedPropertySheetPage.java:555) at org.eclipse.ui.views.properties.PropertySheet.selectionChanged(PropertySheet.java:464) at org.eclipse.ui.internal.e4.compatibility.SelectionService.notifyListeners(SelectionService.java:259) at org.eclipse.ui.internal.e4.compatibility.SelectionService.handlePostSelectionChanged(SelectionService.java:133) at org.eclipse.ui.internal.e4.compatibility.SelectionService.access$1(SelectionService.java:123) at org.eclipse.ui.internal.e4.compatibility.SelectionService$3.selectionChanged(SelectionService.java:81) at org.eclipse.e4.ui.internal.workbench.SelectionAggregator$4.run(SelectionAggregator.java:166) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42) at org.eclipse.e4.ui.internal.workbench.SelectionAggregator.notifyPostListeners(SelectionAggregator.java:163) at org.eclipse.e4.ui.internal.workbench.SelectionAggregator.access$8(SelectionAggregator.java:161) at org.eclipse.e4.ui.internal.workbench.SelectionAggregator$8$1.run(SelectionAggregator.java:271) at org.eclipse.e4.core.contexts.RunAndTrack.runExternalCode(RunAndTrack.java:56) at org.eclipse.e4.ui.internal.workbench.SelectionAggregator$8.changed(SelectionAggregator.java:268) at org.eclipse.e4.core.internal.contexts.TrackableComputationExt.update(TrackableComputationExt.java:114) at org.eclipse.e4.core.internal.contexts.EclipseContext.processScheduled(EclipseContext.java:343) at org.eclipse.e4.core.internal.contexts.EclipseContext.set(EclipseContext.java:358) at org.eclipse.e4.ui.internal.workbench.SelectionServiceImpl.setPostSelection(SelectionServiceImpl.java:36) at org.eclipse.ui.internal.e4.compatibility.CompatibilityPart$3.selectionChanged(CompatibilityPart.java:131) at org.eclipse.ui.part.PageBookView$SelectionManager$1.run(PageBookView.java:263) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42) at org.eclipse.ui.part.PageBookView$SelectionManager.selectionChanged(PageBookView.java:260) at org.eclipse.ui.part.PageBookView$SelectionProvider.postSelectionChanged(PageBookView.java:331) at org.eclipse.ui.part.PageBookView.postSelectionChanged(PageBookView.java:916) at org.eclipse.ui.part.PageBookView.access$3(PageBookView.java:911) at org.eclipse.ui.part.PageBookView$3.selectionChanged(PageBookView.java:179) at org.eclipse.jface.viewers.StructuredViewer$3.run(StructuredViewer.java:878) at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42) at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:50) at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:173) at org.eclipse.jface.viewers.StructuredViewer.firePostSelectionChanged(StructuredViewer.java:875) at org.eclipse.jface.viewers.StructuredViewer.handlePostSelect(StructuredViewer.java:1244) at org.eclipse.ui.navigator.CommonViewer.handlePostSelect(CommonViewer.java:457) at org.eclipse.jface.viewers.StructuredViewer$5.widgetSelected(StructuredViewer.java:1270) at org.eclipse.jface.util.OpenStrategy.firePostSelectionEvent(OpenStrategy.java:265) at org.eclipse.jface.util.OpenStrategy.access$5(OpenStrategy.java:259) at org.eclipse.jface.util.OpenStrategy$1.lambda$1(OpenStrategy.java:431) at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35) at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:182) at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4203) at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3819) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1121) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336) at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1022) at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:150) at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:687) at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336) at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:604) at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:148) at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:138) at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134) at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388) at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:673) at org.eclipse.equinox.launcher.Main.basicRun(Main.java:610) at org.eclipse.equinox.launcher.Main.run(Main.java:1519) at org.eclipse.equinox.launcher.Main.main(Main.java:1492)
I tried to reproduce this using the tester setup for Papyrus-RT (https://wiki.eclipse.org/Papyrus-RT/Tester_Guide) and updated with the latest Papyrus-RT build (based on the latest Papyrus release, Neon.1), following the steps to reproduce. I was curious myself, since I had never seen this before. I did not get exception, and the table shows up in the properties view. The steps to reproduce is a bit unclear regarding if you should check the properties view before or after selecting the protocol message. I assumed that the properties view should be open before the protocol message is selected. Or did you take some other steps prior to getting the error? Could you please elaborate a bit more in the steps to reproduce. PS. It would also help if the zip-file contained the complete project directory. In that way it becomes much easier to import into your workspace when trying to reproduce/test, since you simply can use File > Import... > Existing Projects into Workspace and then use Select archive file. When I write Bugzillas with attached example models, I always zip together the complete project to make this step easier... PPS. I guess we also should create, or reuse an existing, Bugzilla on the Papyrus-RT side, that is blocked by this Bugzilla, to be able to track this in Papyrus-RT.
Assigning bug to myself, to investigate and trying to reproduce. If this bug is valid, I will create the proxy bug on Papyrus-RT project, as advised by Peter.
(In reply to Peter Cigehn from comment #1) > I tried to reproduce this using the tester setup for Papyrus-RT > (https://wiki.eclipse.org/Papyrus-RT/Tester_Guide) and updated with the > latest Papyrus-RT build (based on the latest Papyrus release, Neon.1), > following the steps to reproduce. I was curious myself, since I had never > seen this before. I did not get exception, and the table shows up in the > properties view. The steps to reproduce is a bit unclear regarding if you > should check the properties view before or after selecting the protocol > message. I assumed that the properties view should be open before the > protocol message is selected. Or did you take some other steps prior to > getting the error? Could you please elaborate a bit more in the steps to > reproduce. > > PS. It would also help if the zip-file contained the complete project > directory. In that way it becomes much easier to import into your workspace > when trying to reproduce/test, since you simply can use File > Import... > > Existing Projects into Workspace and then use Select archive file. When I > write Bugzillas with attached example models, I always zip together the > complete project to make this step easier... > > PPS. I guess we also should create, or reuse an existing, Bugzilla on the > Papyrus-RT side, that is blocked by this Bugzilla, to be able to track this > in Papyrus-RT. Peter, Steps to reproduce is not very important as long as you open the view that displays the table. What is important is that you start eclipse from fresh workspace so that no previous metadata exist about the table. Nattable xml is written into metadata/.plugins/oep.uml.properties/tables when it is open first time and that's where it fails. So you could manually delete the content of tables directory to test.
Reading the stack trace it seems be the same than Bug 502160. This last one has been fixed on master and streams/2.0-maintenance at the end of septembre.
Bug 502160 is about a command which is not undoable, this one is about an issue on displaying the table. @vincent, do you mean another bug? I could reproduce the bug on my side.
(In reply to Young-Soo Roh from comment #3) > Peter, > Steps to reproduce is not very important as long as you open the view that > displays the table. What is important is that you start eclipse from fresh > workspace so that no previous metadata exist about the table. Nattable xml > is written into metadata/.plugins/oep.uml.properties/tables when it is open > first time and that's where it fails. So you could manually delete the > content of tables directory to test. Well, I am unable to repeat this, even in a new workspace. Not sure though if it is something different with the tester-setup compared to what you have been using. Not sure how important it is that I am unable to get it to repeat. But I guess it would be good though to understand why it does not happen for me using the tester setup. (In reply to Remi Schnekenburger from comment #5) > I could reproduce the bug on my side. Good that you could get it to reproduce. Welcome back, Rémi! :)
(In reply to Peter Cigehn from comment #6) > (In reply to Young-Soo Roh from comment #3) > > Peter, > > Steps to reproduce is not very important as long as you open the view that > > displays the table. What is important is that you start eclipse from fresh > > workspace so that no previous metadata exist about the table. Nattable xml > > is written into metadata/.plugins/oep.uml.properties/tables when it is open > > first time and that's where it fails. So you could manually delete the > > content of tables directory to test. > > Well, I am unable to repeat this, even in a new workspace. Not sure though > if it is something different with the tester-setup compared to what you have > been using. Not sure how important it is that I am unable to get it to > repeat. But I guess it would be good though to understand why it does not > happen for me using the tester setup. > > (In reply to Remi Schnekenburger from comment #5) > > I could reproduce the bug on my side. > > Good that you could get it to reproduce. Welcome back, Rémi! :) I can reproduce on my dev env and Charles can reproduce on his tester env.
(In reply to Young-Soo Roh from comment #7) > (In reply to Peter Cigehn from comment #6) > > (In reply to Young-Soo Roh from comment #3) > > > Peter, > > > Steps to reproduce is not very important as long as you open the view that > > > displays the table. What is important is that you start eclipse from fresh > > > workspace so that no previous metadata exist about the table. Nattable xml > > > is written into metadata/.plugins/oep.uml.properties/tables when it is open > > > first time and that's where it fails. So you could manually delete the > > > content of tables directory to test. > > > > Well, I am unable to repeat this, even in a new workspace. Not sure though > > if it is something different with the tester-setup compared to what you have > > been using. Not sure how important it is that I am unable to get it to > > repeat. But I guess it would be good though to understand why it does not > > happen for me using the tester setup. > > > > (In reply to Remi Schnekenburger from comment #5) > > > I could reproduce the bug on my side. > > > > Good that you could get it to reproduce. Welcome back, Rémi! :) > > I can reproduce on my dev env and Charles can reproduce on his tester env. Is it something platform dependent then? I am using Windows, and from what I have understood, Charles is using Mac, right? Anyway, I am seeing some strange issues with the merged fix for Bug 495146, see Bug 495146 Comment 6. Not sure if this is related to the same kind of aspect. It would be good if someone else could test the merged fix for Bug 495146 using the latest Papyrus-RT build and the tester setup.
(In reply to Peter Cigehn from comment #8) > (In reply to Young-Soo Roh from comment #7) > > (In reply to Peter Cigehn from comment #6) > > > (In reply to Young-Soo Roh from comment #3) > > > > Peter, > > > > Steps to reproduce is not very important as long as you open the view that > > > > displays the table. What is important is that you start eclipse from fresh > > > > workspace so that no previous metadata exist about the table. Nattable xml > > > > is written into metadata/.plugins/oep.uml.properties/tables when it is open > > > > first time and that's where it fails. So you could manually delete the > > > > content of tables directory to test. > > > > > > Well, I am unable to repeat this, even in a new workspace. Not sure though > > > if it is something different with the tester-setup compared to what you have > > > been using. Not sure how important it is that I am unable to get it to > > > repeat. But I guess it would be good though to understand why it does not > > > happen for me using the tester setup. > > > > > > (In reply to Remi Schnekenburger from comment #5) > > > > I could reproduce the bug on my side. > > > > > > Good that you could get it to reproduce. Welcome back, Rémi! :) > > > > I can reproduce on my dev env and Charles can reproduce on his tester env. > > Is it something platform dependent then? I am using Windows, and from what I > have understood, Charles is using Mac, right? > > Anyway, I am seeing some strange issues with the merged fix for Bug 495146, > see Bug 495146 Comment 6. Not sure if this is related to the same kind of > aspect. It would be good if someone else could test the merged fix for Bug > 495146 using the latest Papyrus-RT build and the tester setup. Yes, I am using Windows 10 dev runtime and Charles is using Mac tester env. I don't think this issue is related to strange behaviour from Bug495146 comment#6. I think resizing the column axis in oep.infra.nattable.manager.table.addAxisResizeListener is causing strange behaviour to the table especially with percentage column size is enabled. Strange behaviour disappears if I remove the listener to change column width axis. I left comment on the gerrit https://git.eclipse.org/r/#/c/82277/3
New Gerrit change created: https://git.eclipse.org/r/82546
Gerrit change https://git.eclipse.org/r/82546 was merged to [master]. Commit: http://git.eclipse.org/c/papyrus-rt/org.eclipse.papyrus-rt.git/commit/?id=916ea484cf72e938aaabc59e8831d6e072037785
Fix has been merged. Manual tests performed: - reproduced steps from Young-soo and check that undo/Redo is not proposing some table edition - reproduced steps from Young-soo, but create a new element before displaying the table. After property view is shown, try to undo/redo => the undo is the one from creation. Putting as fixed, so Young soo can work on his dependent task. RCPTT tests could be probably added to check table opens nicely.
Since the fix seem to have been made only in Papyrus-RT, should this Bugzilla be moved over to Papyrus-RT? It feels a bit confusing that it is written on Papyrus. Or are there still aspects which needs to be fixed in base Papyrus? If so, then we cannot those changes into Papyrus 0.8.0, since we are pinned down to Papyrus Neon.1 and have to wait for Papyrus Neon.2 to get in fixes in base Papyrus that Papyrus-RT needs.
(In reply to Peter Cigehn from comment #13) > Since the fix seem to have been made only in Papyrus-RT, should this > Bugzilla be moved over to Papyrus-RT? It feels a bit confusing that it is > written on Papyrus. Or are there still aspects which needs to be fixed in > base Papyrus? If so, then we cannot those changes into Papyrus 0.8.0, since > we are pinned down to Papyrus Neon.1 and have to wait for Papyrus Neon.2 to > get in fixes in base Papyrus that Papyrus-RT needs. Indeed, i did not see this one was targeting papyrus, while the fix was a temporary fix on papyrus-rt. I Will reopen this bug, and open also one on papyrus-rt. 503083 should be fixed for papyrus Neon.2. The bug on papyrus-rt will target the papyrus-rt release based on Neon.2 (papyrus-rt 0.9?). The bug on papyrus-rt will track the removal of the local fix).
New Gerrit change created: https://git.eclipse.org/r/82852
Gerrit change https://git.eclipse.org/r/82852 was merged to [streams/2.0-maintenance]. Commit: http://git.eclipse.org/c/papyrus/org.eclipse.papyrus.git/commit/?id=ea31e71762a6e8ffec229465a96eb5ea3c6df02d
New Gerrit change created: https://git.eclipse.org/r/84792
Gerrit change https://git.eclipse.org/r/84792 was merged to [master]. Commit: http://git.eclipse.org/c/papyrus/org.eclipse.papyrus.git/commit/?id=3be3e8a2c746969c82c304e716c7e9cfd0917e17
Fix pushed on master and maintenance/Neon, closing bug
