Bug 502844 - Project dependencies to modules that are implicitly readable is not resolved
Summary: Project dependencies to modules that are implicitly readable is not resolved
Status: NEW
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 4.7   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: JDT-Core-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-30 06:40 EDT by Chandrakala MS CLA
Modified: 2023-01-21 01:05 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chandrakala MS CLA 2016-09-30 06:40:07 EDT
As per Java9 module system implied readability, 
module B requires public A and module C requires B means, module C can see A without explicitly declaring dependency using requires in module C's module descriptor. 

Eclipse with Java9 support, resolves only explicit dependencies that are declared by a module using requires. Implicitly readable modules are not resolved. 
Will this be implemented?

Tested with eclipse-SDK-Y20160908-1000-win32-x86_64
Comment 1 Jay Arthanareeswaran CLA 2016-09-30 08:19:16 EDT
(In reply to Chandrakala MS from comment #0)
> Will this be implemented?

Of course. It is not clear why this scenario isn't working. We have a unit test for this: 

ModuleBuilderTests#test_ModuleSourcePath_implicitdeps()

which is passing. But there's something fishy. It passes only when run as part of the suite. Fails only when that particular test is run. I will take a look.
Comment 2 Sasikanth Bharadwaj CLA 2016-10-03 01:42:24 EDT
(In reply to comment #1)
> (In reply to Chandrakala MS from comment #0)
> > Will this be implemented?
> 
> Of course. It is not clear why this scenario isn't working. We have a unit test
> for this:
> 
> ModuleBuilderTests#test_ModuleSourcePath_implicitdeps()
> 
> which is passing. But there's something fishy. It passes only when run as part
> of the suite. Fails only when that particular test is run. I will take a look.
Probably running into bug 499429 - there's a kind of chicken and egg situation where you need the package fragment roots initialized to know if a project is a module or not (the ModulePathContainer requires this information to figure out the dependencies), and you need the container to compute the package fragment roots. This leads to situations where things do not work reliably. I have a WIP patch that addresses this by making sure the module is initialized first before we try and compute the roots.
Comment 3 Eclipse Genie CLA 2020-09-26 14:09:11 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 4 Eclipse Genie CLA 2023-01-21 01:05:20 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.