Comment 1 Lars Vogel 2016-09-27 10:34:08 EDT

Sopot, it would be create if PDE had a template for the new editor support. Maybe you can update the "Plug-in with an editor" template with the new approach?

Comment 2 Nobody - feel free to take it 2016-09-27 10:57:40 EDT

Indeed.

Comment 3 Nobody - feel free to take it 2016-09-27 10:59:58 EDT

Maybe creating a new one is better. I could use the .target editor I built https://twitter.com/smcela/status/771315783788027904

WDYT?

Comment 4 Lars Vogel 2016-09-27 11:04:51 EDT

(In reply to Sopot Cela from comment #3)
> Maybe creating a new one is better. I could use the .target editor I built
> https://twitter.com/smcela/status/771315783788027904
> 
> WDYT?

+1 or the XML one. The current PDE template is for XML.

Comment 5 Nobody - feel free to take it 2016-09-28 09:59:41 EDT

Here is a work-in-progress template. Feedback is welcome.

https://sopotc.fedorapeople.org/Screencast%20from%2009-28-2016%2003:00:59%20PM.webm

Comment 6 Mickael Istria 2016-09-28 10:17:56 EDT

Thanks Sopot, that's promising. Some comments/suggestions:
* The template should ideally contain an implementation for all extensions
* There are risk of facing bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=500755
* Template could be named "Plugin with an extensible editor" but rather "Plugin with some language support for Generic Editor"
* Content-type/editor association could be included in the template.
* Template icon could be the one of the Generic Editor

Comment 7 Lars Vogel 2016-09-29 04:48:47 EDT

(In reply to Sopot Cela from comment #5)
> Here is a work-in-progress template. Feedback is welcome.
> 
> https://sopotc.fedorapeople.org/Screencast%20from%2009-28-2016%2003:00:
> 59%20PM.webm

Could you upload a Gerrit?

Comment 8 Eclipse Genie 2016-09-29 06:07:54 EDT

New Gerrit change created: https://git.eclipse.org/r/82151

Comment 9 Mickael Istria 2016-10-05 09:46:33 EDT

I'm questioning the value of a template here for the effort and maintenance it requires: Why not simply allow to load an example, importing the .project editor bundle into the IDE?

Comment 10 Nobody - feel free to take it 2016-10-05 09:49:37 EDT

I think a template is much more visible and handy to start with. Also we already spent the effort so not sure if it makes sense to reconsider the purpose of templates in general at this point.

Comment 11 Alexander Kurtakov 2016-10-05 10:00:33 EDT

Heaving a template is great way to get people kickstarted on something new and getting smth small enough with their stuff sneaked in. E.g. I'm looking towards using this template to generate basic editors for me which I can extend to become diff/patch, suppression and etc. editors. Yes, there is effort in keeping them but their value is huge when trying to make technology easier to use (does powerpoint needs templates?).

Comment 12 Mickael Istria 2016-10-05 10:03:15 EDT

ok ok then... I personally never used a template and always look at existing code or examples, so I probably underestimate their value. However, I'm still surprised of the effort it is in maintaining as they require a lot of code. I thought those were simply all text templates a-la velocity.

Comment 13 Eclipse Genie 2016-10-06 07:12:14 EDT

Gerrit change https://git.eclipse.org/r/82151 was merged to [master].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=08b13b27540d08087909c3feda093ed764fb647d

Comment 14 Lars Vogel 2016-10-06 07:12:33 EDT

Thanks. Leaving open for the N&N entry for PDE.

Comment 15 Eclipse Genie 2016-10-07 10:00:10 EDT

New Gerrit change created: https://git.eclipse.org/r/82737

Comment 16 Eclipse Genie 2016-10-07 11:05:38 EDT

Gerrit change https://git.eclipse.org/r/82737 was merged to [master].
Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=855afa9b5360b1379ac392f7bafaeb124d8ef5f8