Bug 502007 - "New CSS File" template uses wrong @charset directive
Summary: "New CSS File" template uses wrong @charset directive
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.css (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.9 M7   Edit
Assignee: Gautier de SAINT MARTIN LACAZE CLA
QA Contact: Nick Sandonato CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-22 10:50 EDT by Andreas Sewe CLA
Modified: 2017-04-24 20:43 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Sewe CLA 2016-09-22 10:50:16 EDT
The "New CSS File" template offered looks like this:

  @CHARSET "${encoding}";

This is wrong. The CSS specification is very clear that these should be lowercase characters [1], as otherwise charset sniffing must deal with lots of possible variants, not just one canonical byte sequence.

Hence, the template should look like this:

  @charset "${encoding}";

[1] <https://www.w3.org/TR/css-syntax-3/#input-byte-stream>
Comment 1 Eclipse Genie CLA 2016-09-23 04:06:46 EDT
New Gerrit change created: https://git.eclipse.org/r/81763
Comment 2 Andreas Sewe CLA 2017-03-28 06:13:40 EDT
(In reply to Eclipse Genie from comment #1)
> New Gerrit change created: https://git.eclipse.org/r/81763

This (trivial) change has been in Gerrit forever. Anyone willing to have a look?
Comment 3 Gautier de SAINT MARTIN LACAZE CLA 2017-03-29 15:58:10 EDT
I'm not a committer. I can't do my own review. Sorry. :(
Comment 5 Nitin Dahyabhai CLA 2017-04-24 20:43:31 EDT
Merged, thanks!