Bug 502000 - Make TextFileBuffer more flexible
Summary: Make TextFileBuffer more flexible
Status: RESOLVED FIXED
Alias: None
Product: Handly
Classification: Technology
Component: Core (show other bugs)
Version: 0.5   Edit
Hardware: All All
: P3 enhancement
Target Milestone: 0.6   Edit
Assignee: Vladimir Piskarev CLA
QA Contact:
URL:
Whiteboard: breakingchange
Keywords: api
Depends on:
Blocks:
 
Reported: 2016-09-22 09:55 EDT by Vladimir Piskarev CLA
Modified: 2016-09-23 03:42 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Piskarev CLA 2016-09-22 09:55:34 EDT 
Similarly to text file buffers' support of the Eclipse Platform, it should be possible for clients to create an instance of TextFileBuffer for IPath or IFileStore besides IFile.
Comment 1 Vladimir Piskarev CLA 2016-09-23 03:42:46 EDT 
Pushed to master:
http://git.eclipse.org/c/handly/org.eclipse.handly.git/commit/?id=8875d31e471cdb8ef4c3b91d3f8c4ad0f0904e57


Breaking changes:

* TextFileBuffer(IFile, ITextFileBufferManager) -> TextFileBuffer(ICoreTextFileBufferProvider, IProgressMonitor); also a static factory method #forFile(IFile) has been provided for convenience

* getDelegate() has been effectively replaced with getCoreTextFileBufferProvider()


New API:

* ICoreTextFileBufferProvider