Bug 501519 - [content assist] Template proposals have incorrect relevance
Summary: [content assist] Template proposals have incorrect relevance
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.6.2   Edit
Assignee: Noopur Gupta CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 502118 (view as bug list)
Depends on: 488441
Blocks:
  Show dependency tree
 
Reported: 2016-09-15 13:56 EDT by Noopur Gupta CLA
Modified: 2016-12-06 03:27 EST (History)
6 users (show)

See Also:
sarika.sinha: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Noopur Gupta CLA 2016-09-15 13:56:38 EDT 
Steps to reproduce:
- Disable substring matches in the content assist preferences so that only prefix matches are shown.
- Press Ctrl+space after "sys":
public static void main(String[] args) {
	sys|
}
=> Template proposals are listed at the bottom (should be at the top).


Fix for bug 488441 increased the value of R_DEFAULT (in RelevanceConstants.java) which is copied in TemplateProposal.computeRelevance() to adjust the relevance of template proposals. The copied value in jdt.text should also be updated.
Comment 2 Eclipse Genie CLA 2016-09-27 07:00:21 EDT 
New Gerrit change created: https://git.eclipse.org/r/81979
Comment 3 Noopur Gupta CLA 2016-09-27 07:11:13 EDT 
(In reply to Eclipse Genie from comment #2)
> New Gerrit change created: https://git.eclipse.org/r/81979

Sarika, please review for 4.6.2.
Comment 4 Sarika Sinha CLA 2016-09-27 08:58:39 EDT 
(In reply to Noopur Gupta from comment #3)
> (In reply to Eclipse Genie from comment #2)
> > New Gerrit change created: https://git.eclipse.org/r/81979
> 
> Sarika, please review for 4.6.2.

Verified , Fix works in 4.7 and patch for 4.6.2 looks good.

Generally we cherry pick the patch from master to different branch and then in a separate commit, increase the bundle version.
Comment 5 Eclipse Genie CLA 2016-09-29 04:00:31 EDT 
Gerrit change https://git.eclipse.org/r/81979 was merged to [R4_6_maintenance].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=c67912e21bc1d2e94354866ca12c49b9d98334f2
Comment 6 Noopur Gupta CLA 2016-09-29 04:03:21 EDT 
(In reply to Sarika Sinha from comment #4)
> (In reply to Noopur Gupta from comment #3)
> > (In reply to Eclipse Genie from comment #2)
> > > New Gerrit change created: https://git.eclipse.org/r/81979
> > 
> > Sarika, please review for 4.6.2.
> 
> Verified , Fix works in 4.7 and patch for 4.6.2 looks good.

Thanks for the review, Sarika.
 
> Generally we cherry pick the patch from master to different branch and then
> in a separate commit, increase the bundle version.

Sure, I will provide separate commits from next time.
Comment 7 Noopur Gupta CLA 2016-11-17 02:06:27 EST 
Verified as fixed in M20161116-1100.
Comment 8 Noopur Gupta CLA 2016-12-06 03:27:08 EST 
*** Bug 502118 has been marked as a duplicate of this bug. ***