Community
Participate
Working Groups
Created attachment 264171 [details] Screenshot If I have a warning in the ruler and also a breakpoint, the breakpoint marker is not visible. See screenshot. Code snippet to test -------------------- String s = "Test"; // System.out.println(s); -------------------- Maybe you should use a special icon in case there are several markers?
> Maybe you should use a special icon in case there are several markers? I think that would be an easy fix and improve usability. At least I would have a visual indicator for this situation. Adjusted the bug summary accordingly.
See also the discussion in Bug 80089 but I dislike the line of though in this bug, sounds way to complex for this problem. "Configuring the layers" sounds like overdesign for me.
Markers have a PRIORITY, no? Shouldn't the breakpoint marker be a higher priority than the warning marker, but less than the error marker? Would that make this particular situation better? I just worry that using a different visual indicator will still leave people looking for their breakpoints.
(In reply to Doug Schaefer from comment #3) > Markers have a PRIORITY, no? Shouldn't the breakpoint marker be a higher > priority than the warning marker, but less than the error marker? Would that > make this particular situation better? I think this comment should go into Bug 80089. > I just worry that using a different visual indicator will still leave people > looking for their breakpoints. IMMO a new icon would be better than the current status.
(In reply to Lars Vogel from comment #4) > (In reply to Doug Schaefer from comment #3) > > Markers have a PRIORITY, no? Shouldn't the breakpoint marker be a higher > > priority than the warning marker, but less than the error marker? Would that > > make this particular situation better? > > I think this comment should go into Bug 80089. I found that bug to be too general. After talking to a few of my colleagues this specific issue about breakpoints and warnings is bugging lots of people. I don't think the general issue of multiple markers on a line is as important. Of course, neither was important enough to motivate us to fix it, so that should be taken into account as well. > > > I just worry that using a different visual indicator will still leave people > > looking for their breakpoints. > > IMMO a new icon would be better than the current status. That's fair. It would be great if we could get more input and see where the trend is with the community, if there is one.
Created attachment 264184 [details] breakpoint icon concepts Here are some concepts for a combined type of UI element. It uses color so you know there's something different about the line/breakpoint but also has some structural differences for people with color blindness. The far right is actual size.
Breakpoint + Problem may be a typical case, but wouldn't a consistent solution then require to have combined icons for *every* possible combination of markers. Think of TODO markers, bookmarks to begin with. Aren't explicit combination icons a dead end? I'd vote for a generic icon symbolizing just "multiple markers", without even attempting to convey what markers are involved. Or perhaps, just show the marker with highest priority with a *decoration* for "there are more".
(In reply to Stephan Herrmann from comment #7) > I'd vote for a generic icon symbolizing just "multiple markers", without > even attempting to convey what markers are involved. +1, we should target a simple solution
Created attachment 264290 [details] breakpoint multi concept This icon has an outer ring with various colors to differentiate it from the normal breakpoint icon.
Another approach could be to render all annotations like you can see them when enabling Java > Editor > Hovers | Expand vertical ruler icons...
(In reply to Dani Megert from comment #10) > Another approach could be to render all annotations like you can see them > when enabling Java > Editor > Hovers | Expand vertical ruler icons... Dani, I haven't yet met a developer (other than JDT/UI committers :) ) who knows about that preference option (and when I want to show it to s.o., it takes several attempts until I remember/find where to configure this). Can you think of some UI hint that would offer changing this preference whenever you have a pile of icons in the ruler? Perhaps the multi-icon could provide exactly this in its hover? OTOH, I don't think that preference in its current implementation should be enabled by default, because of its confusing behavior regarding breakpoints (i.e., mixing annotations with an additional button).
(In reply to Stephan Herrmann from comment #11) > (In reply to Dani Megert from comment #10) > > Another approach could be to render all annotations like you can see them > > when enabling Java > Editor > Hovers | Expand vertical ruler icons... > > Dani, I haven't yet met a developer (other than JDT/UI committers :) ) who > knows about that preference option (and when I want to show it to s.o., it > takes several attempts until I remember/find where to configure this). > > Can you think of some UI hint that would offer changing this preference > whenever you have a pile of icons in the ruler? Perhaps the multi-icon could > provide exactly this in its hover? One idea is to make the hover richer, like in the editor. In the rich hover we could either show a hint or a button to toggle the preference. > OTOH, I don't think that preference in its current implementation should be > enabled by default, because of its confusing behavior regarding breakpoints > (i.e., mixing annotations with an additional button). Yep, see bug 476676.
(In reply to Dani Megert from comment #12) > (In reply to Stephan Herrmann from comment #11) > > (In reply to Dani Megert from comment #10) > > > Another approach could be to render all annotations like you can see them > > > when enabling Java > Editor > Hovers | Expand vertical ruler icons... > > > > Dani, I haven't yet met a developer (other than JDT/UI committers :) ) who > > knows about that preference option (and when I want to show it to s.o., it > > takes several attempts until I remember/find where to configure this). > > > > Can you think of some UI hint that would offer changing this preference > > whenever you have a pile of icons in the ruler? Perhaps the multi-icon could > > provide exactly this in its hover? > > One idea is to make the hover richer, like in the editor. In the rich hover > we could either show a hint or a button to toggle the preference. Sounds good to me!
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie.
Something in this area still deserves improvement. My preference, though, would be: 1. resolve confusion of roll-over hover, remove add-breakpoint "icon": bug 63725 2. then make roll-over hovers the default: bug 476676 It seems exactly one user is opposing item (1) :)
