Bug 499991 - Straighten an edge
Summary: Straighten an edge
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.1.0   Edit
Assignee: Laurent Redor CLA
QA Contact: Julien Dupont CLA
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2016-08-19 10:53 EDT by Laurent Redor CLA
Modified: 2017-02-17 11:18 EST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Redor CLA 2016-08-19 10:53:10 EDT 
The goal of this evolution is to have 4 commands to straighten an edge (horizontally or vertically).
Comment 1 Eclipse Genie CLA 2016-08-19 11:10:31 EDT 
New Gerrit change created: https://git.eclipse.org/r/79353
Comment 2 Laurent Redor CLA 2016-08-19 11:14:53 EDT 
The gerrit https://git.eclipse.org/r/79353 is the specification of this new feature.
Comment 3 Eclipse Genie CLA 2016-08-26 03:44:17 EDT 
New Gerrit change created: https://git.eclipse.org/r/79795
Comment 4 Eclipse Genie CLA 2016-08-26 03:44:29 EDT 
New Gerrit change created: https://git.eclipse.org/r/79796
Comment 6 Laurent Redor CLA 2016-08-31 04:17:42 EDT 
Gerrit https://git.eclipse.org/r/#/c/79795/ is just a test to move the action "Reset bendpoints". It will not be part of this feature (see chapter "Implementation choices and tradeoffs" of specification [1] for details)

[1] http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/plain/plugins/org.eclipse.sirius.doc/specs/proposal/499991_straightenAnEdge/499991.html?id=b72202baffbff25dc9ea8613eef3ffa25560c96d
Comment 7 Eclipse Genie CLA 2016-09-01 10:04:09 EDT 
New Gerrit change created: https://git.eclipse.org/r/80225
Comment 8 Eclipse Genie CLA 2016-09-01 10:04:11 EDT 
New Gerrit change created: https://git.eclipse.org/r/80224
Comment 10 Eclipse Genie CLA 2016-09-01 16:36:36 EDT 
New Gerrit change created: https://git.eclipse.org/r/80265
Comment 13 Maxime Porhel CLA 2016-09-19 05:58:35 EDT 
Validation steps: 
* Check that the feature documentation is well integrated (https://git.eclipse.org/r/#/c/80265/)
* Play with the new actions and test the documented cases (scope of the feature and limitations).
Comment 15 Florian Barbin CLA 2016-10-03 04:08:21 EDT 
SWTBot tests merged on master
Comment 16 Florian Barbin CLA 2016-10-03 04:39:50 EDT 
Verified
Comment 17 Laurent Redor CLA 2016-10-04 05:19:04 EDT 
The case when the source and target are border nodes and edge centering is activated on both sides. Currently in this case, the straighten actions are disabled, but it is possible to execute them without violating the centering constraint.
Comment 18 Eclipse Genie CLA 2016-10-04 05:23:45 EDT 
New Gerrit change created: https://git.eclipse.org/r/82419
Comment 20 Laurent Redor CLA 2016-10-04 10:05:55 EDT 
Last case of comment 17 i now OK.
Comment 21 Eclipse Genie CLA 2016-10-10 05:07:11 EDT 
New Gerrit change created: https://git.eclipse.org/r/82828
Comment 22 Laurent Redor CLA 2016-10-10 05:15:31 EDT 
The specific case of comment 17 has not been correctly fixed with commit of comment 19. The above commit corresponds to the real fix (and will be in Sirius 4.1.1).
Comment 24 Pierre-Charles David CLA 2016-10-18 11:08:25 EDT 
Available in Sirius 4.1.0, see https://wiki.eclipse.org/Sirius/4.1.0 for details.