Community
Participate
Working Groups
Hi, I'm using the new Equinox launcher to launch an Acceleo generation from Maven. It seems that not all errors cause an error code to be returned. In such situations Maven does not detect that an error occurred. For example, if the given input file does not exist, an error message is displayed but no error code is returned. Checking out the code in http://git.eclipse.org/c/acceleo/org.eclipse.acceleo.git/tree/plugins/org.eclipse.acceleo.equinox.launcher/src/org/eclipse/acceleo/equinox/AcceleoLauncher.java I notice that APPLICATION_ERROR is returned only in the case of invalid command line arguments. The logic should be refactored such that all errors cause APPLICATION_ERROR to be returned so that the calling entity is notified of the failure. Regards, Elie
Hi, good catch, indeed that's an oversight which could bring an interesting improvement ! We'll try to schedule this for the next release but I'm not sure right now to have the bandwith in the next few weeks. That being said that's also an excellent candidate for a contribution so feel free to submit a patchset if you are interested to fix this, once it's integrated you should be able to easily point to the nightly or milestone update-site and use this fix in your continuous integration. Thanks for your feedback !
New Gerrit change created: https://git.eclipse.org/r/81110
Gerrit change https://git.eclipse.org/r/81110 was merged to [master]. Commit: http://git.eclipse.org/c/acceleo/org.eclipse.acceleo.git/commit/?id=314a42f07dacc7f6f5dc94a5d38488df05a1f77e
This is now fixed and will be in the next release. You can use it right away using this update-site: http://download.eclipse.org/acceleo//updates/nightly/3.6.5.201609151523 Cheers and thanks again for your feedback!
