499414 – NoteAttachment attached to Note (or Text) is not deleted when the Note (or Text) is deleted

Bug 499414 - NoteAttachment attached to Note (or Text) is not deleted when the Note (or Text) is deleted

Summary: NoteAttachment attached to Note (or Text) is not deleted when the Note (or Te...

Status:	CLOSED FIXED

Alias:	None

Product:	Sirius
Classification:	Modeling
Component:	Diagram (show other bugs)
Version:	3.0.0
Hardware:	PC All

Importance:	P3 normal (vote)
Target Milestone:	4.1.0
Assignee:	Julien Dupont
QA Contact:

URL:
Whiteboard:	backport
Keywords:

Depends on:
Blocks:	499449 499805
	Show dependency tree

Reported:	2016-08-09 05:06 EDT by Laurent Redor
Modified:	2016-10-18 11:07 EDT (History)
CC List:	1 user (show)

See Also:	468489 427017 Gerrit Change Git Commit Gerrit Change Git Commit Gerrit Change Git Commit

Attachments
NoteAttachmentProject project (2.41 KB, application/x-zip-compressed) 2016-08-09 05:06 EDT, Laurent Redor	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Laurent Redor

2016-08-09 05:06:44 EDT

Created attachment 263524 [details]
NoteAttachmentProject project

Steps to reproduce:
* Import the project NoteAttachmentProject
* Open the diagram "new Diag"
* Delete the Note: The link between Note and Text must be removed
* Undo
* Delete the Text:  The link between Note and Text must be removed

Comment 1 Laurent Redor

2016-08-09 05:09:24 EDT

This regression is caused by bug 427017 (commit [1]).

The NoteAttachment was previouslly removed by the GMF CrossReferencer and the "ViewUtil.destroy(View)".

[1] http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=94b51052cdab27eb399b7c7655c66fecb50a3648

Comment 2 Eclipse Genie

2016-08-09 05:11:20 EDT

New Gerrit change created: https://git.eclipse.org/r/78671

Comment 3 Eclipse Genie

2016-08-09 10:07:59 EDT

Gerrit change https://git.eclipse.org/r/78671 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=3961312b24e647dca40ef3b4460f3f7d6c9d2b9e

Comment 4 Laurent Redor

2016-08-09 11:19:41 EDT

This issue was backported in 3.1.x but it would be interesting to also backport it in 4.0.x.

Comment 5 Laurent Redor

2016-08-12 04:29:16 EDT

A migration is needed to remove note attachments without source or target.

Comment 6 Eclipse Genie

2016-08-12 04:46:59 EDT

New Gerrit change created: https://git.eclipse.org/r/78921

Comment 7 Eclipse Genie

2016-08-12 06:55:58 EDT

Gerrit change https://git.eclipse.org/r/78921 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=3ada41681516cf1fbc96bd5f0b1c5268f50fb1af

Comment 8 Laurent Redor

2016-08-12 11:37:28 EDT

Migration added

Comment 9 Eclipse Genie

2016-08-17 08:00:23 EDT

New Gerrit change created: https://git.eclipse.org/r/79192

Comment 10 Laurent Redor

2016-08-17 09:41:03 EDT

A bug as been discovered in the new migration participant, the above gerrit fixes it.

Comment 11 Eclipse Genie

2016-08-18 03:08:20 EDT

Gerrit change https://git.eclipse.org/r/79192 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=fdf76fd5bdc7ae0dc9c169c9582274ff608ecb59

Comment 12 Pierre-Charles David

2016-10-18 11:07:37 EDT

Available in Sirius 4.1.0, see https://wiki.eclipse.org/Sirius/4.1.0 for details.