Description Jonathan Nieder 2016-08-04 20:11:36 EDT

The JGit server when serving a shallow fetch uses markUninteresting to mark what the client has said it has and markRoot to mark what the client has said it wanted.

The markUninteresting has an unpredictable and difficult to understand effect. See https://git.eclipse.org/r/78398 for how it came up in practice. Some aspects noticed by code inspection:

- unlike PendingGenerator, it doesn't call carryFlagsImpl so the UNINTERESTING flag is not propagated
- since it uses a FIFORevQueue instead of a DateRevQueue, UNINTERESTING commits are visited in the wrong order
- UNINTERESTING commits enter the queue with no assigned depth (depth = -1). Their parents get depth depth+1 (== 0), so walking over them ends early