Bug 498976 - Checking @since tags is very slow to cancel ( for 4.6.1 stream)
Summary: Checking @since tags is very slow to cancel ( for 4.6.1 stream)
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 4.5   Edit
Hardware: PC Windows NT
: P3 normal (vote)
Target Milestone: 4.6.1   Edit
Assignee: Vikas Chandra CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on: 471419
Blocks:
  Show dependency tree
 
Reported: 2016-08-01 04:59 EDT by Vikas Chandra CLA
Modified: 2016-08-17 04:32 EDT (History)
3 users (show)

See Also:
daniel_megert: review+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vikas Chandra CLA 2016-08-01 04:59:51 EDT
+++ This bug was initially created as a clone of Bug #471419 +++

An auto-build takes a very long time to cancel when its status indicates that it is "checking @since tags". IMHO should cancel within at most one second.
Comment 1 Vikas Chandra CLA 2016-08-04 06:27:34 EDT
The fix here is helpful in cancelling the progress bar. Without this, the cancel can take upto 4-5 seconds. The fix is very safe for 4.6.1 and is requested by Ed for 4.6.1.
Comment 2 Vikas Chandra CLA 2016-08-09 04:35:47 EDT
Dani,
This is the gerrit patch for 4.6.1
https://git.eclipse.org/r/78669

Can you please review it for 4.6.1?
Comment 3 Vikas Chandra CLA 2016-08-09 04:36:45 EDT
To recreate this problem ->https://bugs.eclipse.org/bugs/show_bug.cgi?id=471419#c3
Comment 4 Eclipse Genie CLA 2016-08-09 09:07:52 EDT
Gerrit change https://git.eclipse.org/r/78669 was merged to [R4_6_maintenance].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=4bd5e70e8b4c71346443a3f48c1a397ebab3cc45
Comment 5 Eclipse Genie CLA 2016-08-09 09:07:53 EDT
Gerrit change https://git.eclipse.org/r/78669 was merged to [R4_6_maintenance].
Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=4bd5e70e8b4c71346443a3f48c1a397ebab3cc45
Comment 6 Vikas Chandra CLA 2016-08-17 04:32:10 EDT
Cancel works fine on

Version: Neon.1 (4.6.1)
Build id: M20160810-1300