Community
Participate
Working Groups
When entering text for a properties in a EEF Text Widget, if you stop during 500ms, EEF try to validate the current value of the widget to update the EObject. If this value is valid, the EObject is updated otherwise the field is reinitialized with the preceding value. This can be painful when you have to edit a lot of complex values in your metamodel. A solution could be to validate the value when the focus is lost or to be able to configure the validation delay of the widget
New Gerrit change created: https://git.eclipse.org/r/80894
I have pushed a review on Gerrit changing the way the modification of a text field is performed. This review triggers the modification on the loss of the focus of the text field instead of waiting a bit. This modification may not be integrated (or even integrated as is) in EEF but at least with this review we can have a look at how this change could be made and what it would look like.
While not directly related to this issue on the outside, I had to jump through a few hoops in order to prototype a fix for #495036, see https://git.eclipse.org/r/#/c/80827/. Basically, in that other ticket, we want to be able to revert the user's changes in the text field if the "direct edit" tool execution failed. Otherwise the visible text is out of synch with what is actually in the model. In the current implementation the tool execution is done asynchronously in a background thread, which makes the reversal a little complex (but possible). It looks like Stephane's proposed patch here would remove this asynchronous approach, and thus probably impact the other patch (for something simpler probably).
Gerrit change https://git.eclipse.org/r/80894 was merged to [master]. Commit: http://git.eclipse.org/c/eef/org.eclipse.eef.git/commit/?id=d239799732107b697e9f550a1e50d3ee82c48279
New Gerrit change created: https://git.eclipse.org/r/81342
Gerrit change https://git.eclipse.org/r/81342 was merged to [v1.6.x]. Commit: http://git.eclipse.org/c/eef/org.eclipse.eef.git/commit/?id=0ebb6c5272c3e7e01818b0783917242fd8824b50
With version * Sirius 4.1.0.201609201603 * Eef: 1.7.0.201609191510 Setting the feature when the focus is lost introduces a bug when using multiple tab. Indeed the value entered by the user is discarded. To reproduce: 1. Edit a text widget 2. Switch to a different tab 3. Switch back to the first tab The value the user has entered is lost and the feature has not been set.
New Gerrit change created: https://git.eclipse.org/r/81661
Gerrit change https://git.eclipse.org/r/81661 was merged to [master]. Commit: http://git.eclipse.org/c/eef/org.eclipse.eef.git/commit/?id=bbe1961ca86034aa87ff8b56c6e3624b5235e979
New Gerrit change created: https://git.eclipse.org/r/81994
New Gerrit change created: https://git.eclipse.org/r/81995
Gerrit change https://git.eclipse.org/r/81995 was merged to [master]. Commit: http://git.eclipse.org/c/eef/org.eclipse.eef.git/commit/?id=f8bca5090dea3104685dd28f32eebac1073b2511
New Gerrit change created: https://git.eclipse.org/r/84318
See also https://git.eclipse.org/r/#/c/84319/ which "fixes" (more "works around") a potential NPE once https://git.eclipse.org/r/84318 is applied. Steps to reproduce: 1. Open an Ecore Tools diagram and select an EClass. 2. In the 'Main' tab, change its name but do not validate the change (don't hit return, don't select another widget). 3. Click directly on the 'Base' tab. 4. Go back to the 'Main' tab => NPE java.lang.NullPointerException at org.eclipse.eef.properties.ui.api.EEFTabbedPropertySheetPage.processSelectionChanged(EEFTabbedPropertySheetPage.java:500) at org.eclipse.eef.properties.ui.api.EEFTabbedPropertySheetPage.access$0(EEFTabbedPropertySheetPage.java:479) at org.eclipse.eef.properties.ui.api.EEFTabbedPropertySheetPage$1.selectionChanged(EEFTabbedPropertySheetPage.java:206)
There are actually unresolved issues with the new behavior. I'm reopening this one for now, but we may decide to close it and open other tickets for the specific issues left.
Gerrit change https://git.eclipse.org/r/84318 was merged to [master]. Commit: http://git.eclipse.org/c/eef/org.eclipse.eef.git/commit/?id=232b0d66f3a31db5b3ad428aab047accbfc5100c
Gerrit change https://git.eclipse.org/r/84319 was merged to [master]. Commit: http://git.eclipse.org/c/eef/org.eclipse.eef.git/commit/?id=65534ebfb96b493fd4ed54bb2e618e6d7afea2a5
I believe all currently known issues are now fixed. If others appear, please open other, more specific tickets.
