Community
Participate
Working Groups
The confirmation dialog that is popped up when attempting to delete a trace presents [Yes] and [No] buttons, from left to right in this order, no matter the platform. On Gnome/GTK, typically confirmation dialogs will show [Cancel] first, then [OK]. This makes this dialog inconsistent with the rest of the platform. For reference, the "Delete experiment" dialog uses the correct type of dialog and shows the buttons in the platform-defined order. See attached screenshots.
Created attachment 263220 [details] Trace deletion confirmation dialog
Created attachment 263221 [details] Experiment deletion confirmation dialog
It was changed so that we could control it in SWTBot. We could change the one for experiments too.
> It was changed so that we could control it in SWTBot. We could change the one > for experiments too. Please no! The dialog should follow the platform guidelines, the experiment one is the correct one here.
I think the order and the text of the buttons were like that before though (when it was native). But we can change them.
I think there's a way to let JFace use the platform's order of buttons, I'll have to double check.
Created attachment 263222 [details] Bookmark deletion confirmation By chance, I found a dialog that seems to do what we want: [Yes][No] but order by the platform order. It appears when we attempt to delete a bookmark. Although [No] should the option selected by default!
(In reply to Alexandre Montplaisir from comment #7) > Although [No] should the option selected by default! About that, I was looking for such a dialog in gnome "apps", to use as comparison to make sure we're doing things right. I've found shift-delete in Nautilus... but it actually defaults to "Delete" not cancel! Do you know other ones?
I'm basing myself off their design guidelines: https://developer.gnome.org/hig/stable/buttons.html.en > In a dialog, one button may be made the default button, which is shown > with a different border and is activated by pressing Return. Often this > will be the OK or equivalent button. However, if pressing this button by > mistake could cause a loss of data, do not set a default button for the > window. I think we can consider deleting a trace (and its configuration, supplementary files, etc.) to be a "loss of user data". It seems Nautilus isn't even following the Gnome guidelines! And it's not just Gnome, even the "big guys" have similar rules: https://developer.apple.com/library/mac/documentation/UserExperience/Conceptual/OSXHIGuidelines/WindowDialogs.html > Don’t use a default button if the user’s most likely action is dangerous. > An example of a dangerous action is one that causes a loss of user data. > ...
(In reply to Alexandre Montplaisir from comment #9) > I'm basing myself off their design guidelines: > > https://developer.gnome.org/hig/stable/buttons.html.en Thanks, that's what I was looking for.
