Bug 497702 - The edge selection between two border node can be impossible regarding the zoom factor and style.
Summary: The edge selection between two border node can be impossible regarding the zo...
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 4.0.0   Edit
Hardware: PC Windows NT
: P3 normal (vote)
Target Milestone: 4.1.0   Edit
Assignee: Pierre Guilet CLA
QA Contact: Julien Dupont CLA
URL:
Whiteboard:
Keywords: triaged
: 497695 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-07-11 12:18 EDT by Pierre Guilet CLA
Modified: 2016-10-18 11:07 EDT (History)
3 users (show)

See Also:


Attachments
Sirius project to reproduce (4.79 KB, application/zip)
2016-07-11 12:18 EDT, Pierre Guilet CLA
no flags Details
bug visual (25.46 KB, image/png)
2016-07-12 03:59 EDT, Pierre Guilet CLA
no flags Details
bug node selection (34.59 KB, image/png)
2016-07-12 04:06 EDT, Pierre Guilet CLA
no flags Details
Project to test with sequence diagram (4.77 KB, application/x-zip)
2016-07-21 10:35 EDT, Pierre Guilet CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre Guilet CLA 2016-07-11 12:18:26 EDT
Created attachment 263020 [details]
Sirius project to reproduce

In Sirius we have a functionnality allowing to expand the selection box around a border node when it is very small to facilitate the selection.

We have two cases regarding bordered node selection when it is connected to an edge.

Either the style of the node produces a visual size equals or greater than 20px. In this case, the bordered node selection box is the size of it.

Or the visual size of the node is below 20px. In this case we expand the selection box around it too have a minimum usable selection box that does not require that the user clicks a thousand times to select the border node.  

Currently the expansion of the selection box on a bordered node connected to an edge can expand over the selection box of an edge if the visual style is too small. 

In this case if the two bordered node are closed, it is possible to not being able to select the edge at all because the selections box of the two nodes are upon the selection box of the edge and have the priority over the edge selection. 

This cans happen with no zoom.

The problem with the zoom is that the realization of the expansion is currently based on the bordered nodes dimensions without zoom. So if we zoom and we have an acceptable box selection around the bordered node zoomed, we still expand the selection box with a width and edge based on the small visual version whereas we don't want too. 


Steps to reproduce:

-Open the diagram representation "new diag_ecore".
-Click on the edge around the nodes. YOu will not be able to select the edge everywhere.
-Zoom out or in, the hidden edge portion will be the same whatever the zoom used.
Comment 1 Maxime Porhel CLA 2016-07-12 03:37:44 EDT
*** Bug 497695 has been marked as a duplicate of this bug. ***
Comment 2 Maxime Porhel CLA 2016-07-12 03:48:45 EDT
Sequence diagrams might also be impacted. 
It would also be nice to think about Sequence diagram during non-regression tests.
Comment 3 Pierre Guilet CLA 2016-07-12 03:59:56 EDT
Created attachment 263039 [details]
bug visual

We can see that the bordered node is selected whereas it should be the edge.
Comment 4 Pierre Guilet CLA 2016-07-12 04:06:17 EDT
Created attachment 263040 [details]
bug node selection

The problem also occurs with node selection when they are too close and too small.
When trying to select one of the node, it select the other like in the attachement
Comment 5 Pierre Guilet CLA 2016-07-21 10:35:34 EDT
Created attachment 263242 [details]
Project to test with sequence diagram

A test must be done with the sequence diagram to verify the mechanism is working :
Steps to verify :
1-Open the sequence diagram "Sequence diagram on" in the project "edgeSelectionSequenceDiagram" 
2-Click on the diagram background and apply the filter "Collapse Execution"
3-Click on the edge on the right of the arrow M3
Comment 7 Eclipse Genie CLA 2016-08-01 10:06:38 EDT
New Gerrit change created: https://git.eclipse.org/r/78264
Comment 9 Pierre-Charles David CLA 2016-10-18 11:07:38 EDT
Available in Sirius 4.1.0, see https://wiki.eclipse.org/Sirius/4.1.0 for details.