Bug 497449 - Improve technically the collapse of regions
Summary: Improve technically the collapse of regions
Status: NEW
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2016-07-07 02:57 EDT by Laurent Redor CLA
Modified: 2016-07-07 03:23 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Redor CLA 2016-07-07 02:57:01 EDT 
As explained in commits [1] and [2], the height and width have been set to -1 in AirXYLayoutEditPolicy.getConstraintFor(Request, GraphicalEditPart, Rectangle) for facility reason:
* commit [1] to react to show/hide label
* commit [2] to react to collapse of horizontal stack regions.

I think it would be better to directly handle these constraint in the "resize" commands:
* RegionCollapseAwarePropertyHandlerEditPolicy.getLayoutConstraintsCommand(boolean, Command) for collapse case
* Another policy/request for show/hide label case

[1] http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=77d6b28496cd23c13e37484c66b12358b9f33bf4
[2] http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=656a1a52e2e29e08e77d783fa2e690a140311ffb