Bug 497213 - [regression] Syntax coloring blinks when editing and flow control folding is enabled
Summary: [regression] Syntax coloring blinks when editing and flow control folding is ...
Status: NEW
Alias: None
Product: CDT
Classification: Tools
Component: cdt-editor (show other bugs)
Version: Next   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-04 03:17 EDT by Andris Zeila CLA
Modified: 2020-09-04 15:17 EDT (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andris Zeila CLA 2016-07-04 03:17:08 EDT
Well, blinks might be not the right term, but it appears to reset for a split second to the black/normal color setting. And this happens only when editing large files (1000-2000+ lines of code) with flow control folding enabled.

Steps to repeat:
1) set comments color to something else than black
2) enable flow control folding option (restart eclipse if the option was not enabled before)
3) open large C file
4) make some change (typing single character is enough)
5) after a second the comments color resets to black for ~0.5 seconds

Few observations:
1) Didn't seem to affect keyword coloring, but the braces did recvert to normal and then back to the bold. 
2) Changing folding options without restarting  did not affect this behaviour. Only after restarting eclipse the 'blinking' started or stopped.
3) Most probably the 'blink' time depends on the source file size - so with small files I was simply unabled to notice it.
4) I had no such problems with CDT 8.8

I'm running eclipse on Oracle jre 1.8.0_92, Linux. Hardware - i7, ssd, 8gb memory.
Comment 1 Nathan Ridge CLA 2016-07-07 00:33:54 EDT
Confirmed - I can reproduce the problem with CDT 9.0, but not with CDT 8.8.
Comment 2 Andris Zeila CLA 2016-07-07 04:13:17 EDT
Also I'm observing similar behaviour when pressing '/' inside multiline comments. While it's not as disturbing, the cause might be similar.
Comment 3 Nathan Ridge CLA 2016-07-07 19:00:31 EDT
In an attempt to figure out what change regressed this, I built CDT 8.8 against the Eclipse Platform 4.6 - and found that with that build, I *could* reproduce the problem!

That means this is not a regression from CDT 8.8 to CDT 9.0, but a regression from Eclipse Platform 4.5 to Eclipse Platform 4.6.

Changing component field accordingly.
Comment 4 pedro carvalho CLA 2016-07-20 20:43:01 EDT
Hi, just wanted to add that i get the same behaviour even in smaller PHP files ( 400-ish lines ) but surely, in files with less 150 lines this bug didn't appear.

Also, it made a difference in PHP files that mixed html and PHP. Larger files with just php, didn't show this flashing text.



thank you for looking into this!

Eclipse for PHP Developers
Version: Neon Release (4.6.0)
Build id: 20160613-1800

I use a couple of other plugins, if you find it useful, i can send my installation details.
Comment 5 Nathan Ridge CLA 2016-12-28 17:57:59 EST
I am now seeing this as well (with CDT), and it's rather distracting.

Is anyone experiencing this with JDT? Or is it some consequence of how CDT and PDT are using the Platform APIs that JDT is managing to avoid?
Comment 6 Nathan Ridge CLA 2016-12-28 18:05:44 EST
(In reply to Nathan Ridge from comment #5)
> I am now seeing this as well (with CDT), and it's rather distracting.

Hmm - actually, in my case, the problem does not seem to require code folding being enabled, but does seem to be specific to editing a multi-line comment. I wonder if that's the same issue.
Comment 7 Dani Megert CLA 2017-01-04 10:00:08 EST
Sorry, we're not going to investigate CDT issues and the Platform does not provide a flow control feature. If you can provide steps that involve JDT or a test case that does not involve CDT, then please move back.
Comment 8 Nathan Ridge CLA 2017-01-04 13:15:17 EST
(In reply to Dani Megert from comment #7)
> If you can provide steps that involve JDT or a test case that does not involve CDT, then please move back.

What form might a test case that does not involve CDT take?

For example, supposing that the underlying regression is in ProjectionViewer, is there a test suite for ProjectionViewer to which one could try adding a test case that reproduces the issue?
Comment 9 Dani Megert CLA 2017-01-06 12:41:01 EST
(In reply to Nathan Ridge from comment #8)
> (In reply to Dani Megert from comment #7)
> > If you can provide steps that involve JDT or a test case that does not involve CDT, then please move back.
> 
> What form might a test case that does not involve CDT take?
> 
> For example, supposing that the underlying regression is in
> ProjectionViewer, is there a test suite for ProjectionViewer to which one
> could try adding a test case that reproduces the issue?

We have /org.eclipse.text.tests/projection