Bug 497197 - Git staging view should waste less empty space
Summary: Git staging view should waste less empty space
Status: NEW
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-03 12:56 EDT by Lars Vogel CLA
Modified: 2019-12-06 04:47 EST (History)
3 users (show)

See Also:


Attachments
Screenshot (49.72 KB, image/png)
2016-07-03 13:32 EDT, Lars Vogel CLA
no flags Details
Screenshot (119.21 KB, image/png)
2018-09-14 09:18 EDT, Lars Vogel CLA
no flags Details
Still bad (143.37 KB, image/png)
2019-12-02 08:18 EST, Lars Vogel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2016-07-03 12:56:54 EDT
The current placement of the repository information takes to much space. During normal work, the developer knows which repo he is working on and the place for the repository becomes wasted space.

This information fits well into the first section, as this reads as a header for the whole UI.

Gerrit coming soon.
Comment 1 Andrey Loskutov CLA 2016-07-03 13:12:58 EDT
Lars, can you attach a screenshot with the proposal? Might be I misunderstand this, but how one would know what one commits then?

Probably we can optimize the space or show the information differently (view title or status line?), but simply removing it is not OK for me.
Comment 2 Lars Vogel CLA 2016-07-03 13:32:06 EDT
Created attachment 262877 [details]
Screenshot
Comment 3 Lars Vogel CLA 2016-07-03 14:04:22 EDT
Gerrit linking did not work: https://git.eclipse.org/r/76475
Comment 4 Andrey Loskutov CLA 2016-07-04 02:59:54 EDT
(In reply to Lars Vogel from comment #2)
> Created attachment 262877 [details]
> Screenshot

A-ha, the bug title doesn't really match the change. 

In this case (optimizing space) I would rather move the repo information over the commit area, because usually much more space is needed over the "staged/unstaged files" list block, and the "commit" block is usually empty or not so crowded.
Comment 5 Thomas Wolf CLA 2016-07-10 08:43:35 EDT
(In reply to Andrey Loskutov from comment #4)
> (In reply to Lars Vogel from comment #2)
> > Created attachment 262877 [details]
> > Screenshot
> 
> A-ha, the bug title doesn't really match the change. 
> 
> In this case (optimizing space) I would rather move the repo information
> over the commit area, because usually much more space is needed over the
> "staged/unstaged files" list block, and the "commit" block is usually empty
> or not so crowded.

Hm. I don't find that screenshot particularly compelling. Putting the repo info in either title will lead to wrapping if the window/part stack is small, which looks strange and may cause the title bar to become larger? How about harmonizing the layout a bit with the Git history page, and simply using viewPart.setContentDescription() instead of a huge form title? I don't need the repo to be shown in huge bold font.
Comment 6 Lars Vogel CLA 2018-09-14 09:18:45 EDT
Created attachment 275819 [details]
Screenshot
Comment 7 Lars Vogel CLA 2018-09-14 09:19:39 EDT
I rephrase the bug: IMHO Git staging view should waste less empty space. Screen space in the IDE is important and should not be used for intensive whitespace.
Comment 8 Thomas Wolf CLA 2018-09-14 09:25:05 EDT
(In reply to Lars Vogel from comment #7)
> I rephrase the bug: IMHO Git staging view should waste less empty space.
> Screen space in the IDE is important and should not be used for intensive
> whitespace.

The fact that the repo info is not on the same line as the view toolbar would have to be tackled in the CTabFolder or View renderer.

Otherwise, see comment 5 (but that description would still appear below the view toolbar and thus still "waste" a some screen real estate).
Comment 9 Lars Vogel CLA 2019-12-02 08:18:33 EST
Created attachment 280832 [details]
Still bad

How it look on the beamer.
Comment 10 Lars Vogel CLA 2019-12-06 04:47:16 EST
One option to reduce the waste of space would be to hide the Author and Commit fields as they are rarely changed during usage.