Bug 497038 - [TMF] Custom parser field names conflict with built-in tags
Summary: [TMF] Custom parser field names conflict with built-in tags
Status: NEW
Alias: None
Product: Tracecompass
Classification: Tools
Component: TMF (show other bugs)
Version: 2.0.0   Edit
Hardware: PC Windows 7
: P3 normal
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Project Inbox CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-29 16:54 EDT by Patrick Tasse CLA
Modified: 2016-07-20 17:20 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Tasse CLA 2016-06-29 16:54:19 EDT
In the custom parser wizards, input fields are defined with a tag combo which has some built-in values (Ignore, Time Stamp, Event type, Message and Other). For the Other value a name text must be filled.

Both internally and in the XML definition, a single name string is used to represent this. If the Other tag is selected, the name text is used, otherwise the tag's name is used. This means that a user can select the Other tag and enter a string that conflicts with the built-in tag names.

For example typing the name 'Ignore' causes the field to be ignored. Typing the name 'Message' will get the field converted to the Message tag after saving and reloading. Typing the name 'Time Stamp' will cause a NullPointerException because the format field is expected to be present.

The tag's value should be part of the model and the XML definition. The name string should be optional and should be present when the tag is Other.

The implementation should be backward compatible with the older format of the XML definition.
Comment 1 Eclipse Genie CLA 2016-06-29 17:34:51 EDT
New Gerrit change created: https://git.eclipse.org/r/76257