Bug 496742 - Inconsistent GMF size after regions reorder
Summary: Inconsistent GMF size after regions reorder
Status: NEW
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 3.1.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2016-06-24 11:18 EDT by Laurent Redor CLA
Modified: 2022-07-20 04:25 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Laurent Redor CLA 2016-06-24 11:18:28 EDT
When there is a reorder of regions in a vertical stack container, if the reorder impacts the first region, the GMF size becomes inconsistent according to draw2d bounds. This is probably because the first region has not the 1 pixel separator, contrary to the others regions.
Comment 1 Eclipse Genie CLA 2016-06-24 11:46:39 EDT
New Gerrit change created: https://git.eclipse.org/r/75937
Comment 2 Laurent Redor CLA 2016-06-24 11:49:24 EDT
The above gerrit reveals the problem by removing "-1" or "+1" added explicitly to workaround the problem in checks of this test.
Comment 3 Laurent Fasani CLA 2016-07-01 04:00:44 EDT
please could you provide a test scenario?
Comment 4 Pierre-Charles David CLA 2016-07-05 03:58:28 EDT
There's no manual scenario, but the gerrit referenced above provides an automated test that reveals the problem.
Comment 5 Laurent Redor CLA 2022-07-20 04:25:25 EDT
The gerrit has just been rebase (without new analysis) but as asked by Laurent F., steps to reproduce are (part of the automatic test of the gerrit):
* Launch a runtime (with the Sirius Debugging View available)
* Import project CompartmentsTest from CompartmentsTest.zip
* Open the diagram VStackDiag
* Open the Sirius Debugging View
* Select Left_class1
* Expected: The Draw2D height is 91.
* Select Center_class2
* Expected: The GMF and the Draw2D y is 91.
* Open My.ecore with the Sample Model Ecore Model Editor.
* Move Center_class2 above Left_class1
* Save
* Expected: The diagram is refreshed and the order is chanegd.
* Select Center_class2
* Expected: The Draw2D height is 91.
* Select Left_class1
* Expected: The GMF and the Draw2D y is 91, but GMF is 92 instead of 91.