Bug 496458 - [designer][java][reverse] Java reverse doesn't take into account the creation path set in dialogs
Summary: [designer][java][reverse] Java reverse doesn't take into account the creation...
Status: NEW
Alias: None
Product: Papyrus
Classification: Modeling
Component: Designer (show other bugs)
Version: 0.7.1   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Cedric Dumoulin CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-21 08:22 EDT by Cedric Dumoulin CLA
Modified: 2016-06-21 10:16 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cedric Dumoulin CLA 2016-06-21 08:22:10 EDT 
The Java reverse doesn'nt take into account the creation paths set into the popup dialog.
The dialog allows to change the creation paths, but the implementation do not take into account the values. 
Actually, the default creation paths, specified in CreationPackageCatalog are used.
This forbid to use other creation paths, especially one specifying that everything should be created a the root of the model.
Comment 1 Shuai Li CLA 2016-06-21 08:51:34 EDT 
This was fixed by the patch that was merged to master:

https://git.eclipse.org/r/#/c/75062/
"Creation paths from dialog now handled"

I also have the commit locally in the javaOriginalGenReverse branch.
Comment 2 Shuai Li CLA 2016-06-21 08:53:54 EDT 
If you need the fixes from [1] in the javaOriginalGenReverse branch, I think the best is to push your latest commits to javaOriginalGenReverse, then I rebase the fixes from [1], and then push to javaOriginalGenReverse.

[1] https://git.eclipse.org/r/#/c/75062/
Comment 3 Cedric Dumoulin CLA 2016-06-21 09:52:48 EDT 
I have pushed my changes in javaOriginalGenReverse branch. 
Can you try to rebase your work ?
Comment 4 Shuai Li CLA 2016-06-21 09:55:48 EDT 
Yes I'm doing it. Only 2 minor conflicts. Do you have any other commits to push? I'm thinking about merging everything from javaOriginalGenReverse to master. We can then work from master directly.
Comment 5 Cedric Dumoulin CLA 2016-06-21 10:16:28 EDT 
My last changes are pushed. It is related to bug 496471, so it should not create new conflicts.
You can merge and switch to master.

But the actual code really need some cleaning. I will do it after the switch.