Bug 496061 - It should be possible to apply the default rules as a fallback even if some rules exist for some elements
Summary: It should be possible to apply the default rules as a fallback even if some r...
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Properties (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.1.0   Edit
Assignee: Melanie Bats CLA
QA Contact:
URL: https://tuleap.eclipse.org/plugins/tr...
Whiteboard:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2016-06-14 04:23 EDT by Pierre-Charles David CLA
Modified: 2016-10-18 11:09 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre-Charles David CLA 2016-06-14 04:23:02 EDT 
Currently, as soon as we define even a single user rule in the VSM, which may only apply to elements of type T, the default rules are completely disabled for all types, including the ones we did not define any rule for ("all or nothing" effect).

We the specifier defnes a Property View Description, he should be able to indicate whether these rules apply instead of (current behavior) or in addition to the default rules.
Comment 1 Pierre-Charles David CLA 2016-09-13 05:46:22 EDT 
For 4.1, we'll simply add an action in the VSM editor to inline a copy of the default rules. The specifier can then tweak them to only be used for elements for which he does provide other, more specific, page definitions.

We'll have to take care of not using any internal-only mechanism in the default rules, as this means they will be exposed to specifiers.
Comment 2 Eclipse Genie CLA 2016-10-03 10:18:42 EDT 
New Gerrit change created: https://git.eclipse.org/r/82362
Comment 4 Pierre-Charles David CLA 2016-10-05 02:46:21 EDT 
This is done except for missing documentation.
Comment 5 Eclipse Genie CLA 2016-10-07 03:51:20 EDT 
New Gerrit change created: https://git.eclipse.org/r/82700
Comment 7 Pierre-Charles David CLA 2016-10-07 05:45:50 EDT 
Fixed. FIWI, I've reworked the previous solution to avoid highjacking the very first menu. It doesn't look like a MenuBuilder-based approach would have allowed that (or at least given the time available I wasn't able to find how).
Comment 8 Pierre-Charles David CLA 2016-10-18 11:09:18 EDT 
Available in Sirius 4.1.0, see https://wiki.eclipse.org/Sirius/4.1.0 for details.