495415 – Bad attempt to compute absolute value of signed 32-bit hashcode

Bug 495415 - Bad attempt to compute absolute value of signed 32-bit hashcode

Summary: Bad attempt to compute absolute value of signed 32-bit hashcode

Status:	NEW

Alias:	None

Product:	Tracecompass
Classification:	Tools
Component:	TMF (show other bugs)
Version:	2.0.0
Hardware:	PC Linux

Importance:	P3 normal
Target Milestone:	---
Assignee:	Project Inbox
QA Contact:	Project Inbox

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2016-06-03 10:55 EDT by Matthew Khouzam
Modified:	2016-06-04 00:01 EDT (History)
CC List:	0 users

See Also:	Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Matthew Khouzam

2016-06-03 10:55:33 EDT

Hashcodes should not be Math.abs(int) as they can be Integer.MIN_VALUE.

This is a problem as

Math.abs(Integer.MIN_VALUE)==Integer.MIN_VALUE

Comment 1 Eclipse Genie

2016-06-04 00:00:39 EDT

New Gerrit change created: https://git.eclipse.org/r/74533

Comment 2 Eclipse Genie

2016-06-04 00:01:42 EDT

Gerrit change https://git.eclipse.org/r/74533 was merged to [master].
Commit: http://git.eclipse.org/c/tracecompass/org.eclipse.tracecompass.git/commit/?id=8b0730f435890afe5ad6a61a1880d963ce8d7705