Bug 495342 - org.eclipse.jdt.internal.corext.refactoring.structure.PullUpRefactoringProcessor.checkAccesses(IProgressMonitor) doesn't check constructors for accessibility
Summary: org.eclipse.jdt.internal.corext.refactoring.structure.PullUpRefactoringProces...
Status: NEW
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1   Edit
Hardware: Macintosh Mac OS X
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: JDT-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-02 15:46 EDT by Raffi Khatchadourian CLA
Modified: 2016-06-03 16:59 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raffi Khatchadourian CLA 2016-06-02 15:46:37 EDT 
org.eclipse.jdt.internal.corext.refactoring.structure.PullUpRefactoringProcessor.checkAccesses(IProgressMonitor) checks accessed methods of the pulled up members but this method actually ignores constructors. Particularly, org.eclipse.jdt.internal.corext.refactoring.structure.PullUpRefactoringProcessor.checkAccessedMethods(IProgressMonitor, ITypeHierarchy) uses org.eclipse.jdt.internal.corext.refactoring.structure.ReferenceFinderUtil.getMethodsReferencedIn(IJavaElement[], WorkingCopyOwner, IProgressMonitor) to find methods accessed by the pulled up members. That method doesn't return referenced constructors.


-- Configuration Details --
Product: Eclipse 4.5.2.20160218-0600 (org.eclipse.epp.package.committers.product)
Installed Features:
 org.eclipse.jdt 3.11.2.v20160212-1500
Comment 1 Jay Arthanareeswaran CLA 2016-06-03 11:05:15 EDT 
Moving to UI