Bug 49530 - Spelling mistake in the FORMATTER_INSERT_SPACE_BETWEEN_EMPTY_ARGUMENTS string constant
Summary: Spelling mistake in the FORMATTER_INSERT_SPACE_BETWEEN_EMPTY_ARGUMENTS string...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 trivial (vote)
Target Milestone: 3.0 M7   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-01-05 10:38 EST by Olivier Thomann CLA
Modified: 2004-02-11 12:52 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2004-01-05 10:38:28 EST 
It is:
	public static final String FORMATTER_INSERT_SPACE_BETWEEN_EMPTY_ARGUMENTS =
JavaCore.PLUGIN_ID + ".formatter.inset_space_between_empty_arguments";	//$NON-NLS-1$

instead of:
	public static final String FORMATTER_INSERT_SPACE_BETWEEN_EMPTY_ARGUMENTS =
JavaCore.PLUGIN_ID + ".formatter.insert_space_between_empty_arguments";
//$NON-NLS-1$

missing 'r' in "insert".
Comment 1 Olivier Thomann CLA 2004-01-05 11:04:59 EST 
Fixed and released in HEAD.
Comment 2 Silvio Böhler CLA 2004-01-05 11:05:42 EST 
Hmmmmm....it should not break the UI, as I'm never using the particular value
assigned to FORMATTER_INSERT_SPACE_BETWEEN_EMPTY_ARGUMENTS...

EXCEPT when storing profiles, I use the value as an XML parameter value.

So the effect of this change would be that for any existing code formatter
profile, this particular setting would be reset to the default value.

Either I build a migration path (something like this will anyway be needed
sooner or later) or we live with this effect. 

In any case, let's wait with the change. Martin, my personal dedicated Eclipse
committer is currently out-of-office and I should perhaps discuss this with him
first. He'll be back Wednesday AFAIK.

Is this ok for you?
Comment 3 Silvio Böhler CLA 2004-01-05 11:06:59 EST 
Well, too late...
Comment 4 Olivier Thomann CLA 2004-01-05 11:11:10 EST 
I can undo it till Wednesday if you want.
Comment 5 Olivier Thomann CLA 2004-01-05 11:48:54 EST 
Reopen. Fix is deferred till Martin is back.
Comment 6 Olivier Thomann CLA 2004-01-07 12:48:07 EST 
Fixed and released in HEAD.
Comment 7 Frederic Fusier CLA 2004-02-11 12:52:01 EST 
Verified for 3.0-M7 with build I200402102000.