Bug 494269 - Import Projects context menu should open the smart import wizard if Eclipse 4.6 or higher is used
Summary: Import Projects context menu should open the smart import wizard if Eclipse 4...
Status: RESOLVED FIXED
Alias: None
Product: EGit
Classification: Technology
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 4.5   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-23 04:58 EDT by Lars Vogel CLA
Modified: 2016-07-24 17:31 EDT (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2016-05-23 04:58:33 EDT
I think it would improve the user experience if EGit could trigger the new Smart Import Project wizard, if the user selects "Import Projects" from the EGit context menu in Git repository view.
Comment 1 Lars Vogel CLA 2016-05-23 04:59:26 EDT
Mickael, what you do think? I think this could improve the consistency of the import experience.
Comment 2 Mickael Istria CLA 2016-05-23 05:03:06 EDT
Yes, it would make sense.
However, the old-school import wizards may still be useful. I believe that if we go in that directiom, the "open projects..." wizard should have a link to the specific import wizards, something like "Show more specific import operation" on the bottom right, a bit like what the simple EGit push branch dialog does to get to the advanced one.
Comment 3 Andrey Loskutov CLA 2016-05-23 05:36:29 EDT
Just to make sure: egit schould stil work with older Eclipse versions, so implementation schould check first if the new wizard is available at all (e.g. by checking registry).
Comment 4 Eclipse Genie CLA 2016-07-21 16:30:02 EDT
New Gerrit change created: https://git.eclipse.org/r/77724
Comment 5 Tobias Baumann CLA 2016-07-22 03:41:03 EDT
The provided change checks in the registry if the SmartImportWizard is available and if so, it sets the initial import source on the SmartImportWizard using the selection provided from the RepositoryView.

I realized that the change has problems:
- the test broke, but it should be easy to fix.
- I imported the SmartImportWizard directly to provide the initial import source, but it uses internal API.
Comment 6 Andrey Loskutov CLA 2016-07-22 03:44:02 EDT
(In reply to Tobias Baumann from comment #5)
> The provided change checks in the registry if the SmartImportWizard is
> available and if so, it sets the initial import source on the
> SmartImportWizard using the selection provided from the RepositoryView.
> 
> I realized that the change has problems:
> - the test broke, but it should be easy to fix.
> - I imported the SmartImportWizard directly to provide the initial import
> source, but it uses internal API.

Please make sure (download & test) the compiled plugin still works (installable and runs) on Eclipse 3.8.2. I have ~100 developers here which would be very angry :-)
Comment 7 Lars Vogel CLA 2016-07-22 04:11:47 EDT
Andrey, AFAIAFEGit supports only the last two releases. Is that not true?
Comment 8 Lars Vogel CLA 2016-07-22 04:12:18 EDT
(In reply to Lars Vogel Unavailable until 15 August 2016 from comment #7)
> Andrey, AFAIAFEGit supports only the last two releases. Is that not true?

AFAIK EGit supports....
Comment 9 Andrey Loskutov CLA 2016-07-22 04:33:18 EDT
(In reply to Lars Vogel Unavailable until 15 August 2016 from comment #7)
> Andrey, AFAIAFEGit supports only the last two releases. Is that not true?

Not really. I'm trying to keep it 3.8.2 compatible. Our lab is still on 3.8.2.
Comment 10 Tobias Baumann CLA 2016-07-22 06:29:13 EDT
Patch Set 2 provides the same functionality without using internal API.

I fixed the test by removing the smart import wizard form the registry at the beginning. I assume, since there is not internal API usage any more, that there will be no issue with Eclipse 3.8.2.

Many regards.
Comment 11 Eclipse Genie CLA 2016-07-24 17:29:58 EDT
Gerrit change https://git.eclipse.org/r/77724 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=1806b419d0ec4b9c8d24eac5f6a9a65defc710f6
Comment 12 Thomas Wolf CLA 2016-07-24 17:31:05 EDT
Thanks, Tobias!