Bug 494212 - Callstack View action to configure address mapping is disabled if the trace does not populate the view
Summary: Callstack View action to configure address mapping is disabled if the trace d...
Status: ASSIGNED
Alias: None
Product: Tracecompass
Classification: Tools
Component: TMF (show other bugs)
Version: 2.0.0   Edit
Hardware: PC Linux
: P3 normal
Target Milestone: 2.0.0   Edit
Assignee: Alexandre Montplaisir CLA
QA Contact: Project Inbox CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-20 17:25 EDT by Alexandre Montplaisir CLA
Modified: 2016-06-06 14:27 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Montplaisir CLA 2016-05-20 17:25:25 EDT 
There is a button in the Call Stack view to configure the mapping between addresses and function names. This action is only enabled if the trace populates the Call Stack view.

This concept made sense before, but now the address mapping logic is delegated to the ISymbolProvider mechanism, and can be used by analyses other than the Call Stack one. For example, an LTTng-UST 2.8 trace with debug-info events may want to configure the address mapping (for the source lookup action) without providing anything in the Call Stack view.

The fact the action is in the Call Stack view itself is also a problem now, it should be moved to somewhere more "trace-wide". But in the meantime, the action should be enabled for all traces that provide a symbol provider, even if they don't populate the Call Stack view.
Comment 1 Eclipse Genie CLA 2016-05-20 18:25:52 EDT 
New Gerrit change created: https://git.eclipse.org/r/73337
Comment 3 Eclipse Genie CLA 2016-06-04 00:01:31 EDT 
New Gerrit change created: https://git.eclipse.org/r/74551