Bug 493192 - [CustomHiDPI][Win32][GTK] splash screen broken if autoscale disabled
Summary: [CustomHiDPI][Win32][GTK] splash screen broken if autoscale disabled
Status: CLOSED WONTFIX
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Launcher (show other bugs)
Version: 4.6.0 Neon   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Sravan Kumar Lakkimsetti CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks: 495417 495269 534932 538680
  Show dependency tree
 
Reported: 2016-05-08 10:38 EDT by Andrey Loskutov CLA
Modified: 2020-11-30 06:56 EST (History)
7 users (show)

See Also:


Attachments
splash screen after workspace selection is confirmed (521.09 KB, image/png)
2016-05-08 10:38 EDT, Andrey Loskutov CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Loskutov CLA 2016-05-08 10:38:34 EDT
Created attachment 261539 [details]
splash screen after workspace selection is confirmed

I'm using Win 10 with 150% scaling factor and start Eclipse with -Dswt.enable.autoScale=false argument.

Initialy splash screen looks nice. After confirming the workspace selection dialog, it gets somehow damaged, looks like it tries to scale down, see attached picture.
Comment 1 Niraj Modi CLA 2016-05-09 03:47:00 EDT
(In reply to Andrey Loskutov from comment #0)
> Created attachment 261539 [details]
> splash screen after workspace selection is confirmed
> 
> I'm using Win 10 with 150% scaling factor and start Eclipse with
> -Dswt.enable.autoScale=false argument.
> 
> Initialy splash screen looks nice. After confirming the workspace selection
> dialog, it gets somehow damaged, looks like it tries to scale down, see
> attached picture.

Yes, I can reproduce this on Win7 as well.

Possible reason for this issue seems that launcher code doesn't honor -Dswt.enable.autoScale flag.

Solution:
This flag needs to be read from eclipse.ini file and honored in launcher code for auto-scaling for Splash screen.

IMHO, should be targeted for coming Neon RC builds.
Comment 2 Sravan Kumar Lakkimsetti CLA 2016-05-09 04:13:46 EDT
(In reply to Niraj Modi from comment #1)
> (In reply to Andrey Loskutov from comment #0)
> > Created attachment 261539 [details]
> > splash screen after workspace selection is confirmed
> > 
> > I'm using Win 10 with 150% scaling factor and start Eclipse with
> > -Dswt.enable.autoScale=false argument.
> > 
> > Initialy splash screen looks nice. After confirming the workspace selection
> > dialog, it gets somehow damaged, looks like it tries to scale down, see
> > attached picture.
> 
> Yes, I can reproduce this on Win7 as well.
> 
> Possible reason for this issue seems that launcher code doesn't honor
> -Dswt.enable.autoScale flag.
> 
> Solution:
> This flag needs to be read from eclipse.ini file and honored in launcher
> code for auto-scaling for Splash screen.
> 
> IMHO, should be targeted for coming Neon RC builds.

Niraj You are correct in the analysis. This needs to be fixed in the launcher
Comment 3 Eclipse Genie CLA 2016-05-11 06:35:35 EDT
New Gerrit change created: https://git.eclipse.org/r/72490
Comment 4 Niraj Modi CLA 2016-05-17 08:16:47 EDT
(In reply to Eclipse Genie from comment #3)
> New Gerrit change created: https://git.eclipse.org/r/72490

This patch looks good but it not fixing the custom HighDPI part, it actually Adapts the launcher to 'integer' scaling which is default for Eclipse, so lets leave this bug as is for now.

Created a new bug 493797 targeted for NeonRC2 for adapting launcher to 'integer' scaling.
Comment 5 Sravan Kumar Lakkimsetti CLA 2016-05-17 08:27:03 EDT
With the changes to bug 493462, the scope of this bug got changed to customDPI settings. We will fix this in Oxygen. Moving out of Neon
Comment 6 Thomas Watson CLA 2018-05-07 11:51:07 EDT
(In reply to Sravan Kumar Lakkimsetti from comment #5)
> With the changes to bug 493462, the scope of this bug got changed to
> customDPI settings. We will fix this in Oxygen. Moving out of Neon

We are now in Photon at the end of M7.  Anything planned for Photon?
Comment 7 Sravan Kumar Lakkimsetti CLA 2018-05-08 02:05:49 EDT
(In reply to Thomas Watson from comment #6)
> (In reply to Sravan Kumar Lakkimsetti from comment #5)
> > With the changes to bug 493462, the scope of this bug got changed to
> > customDPI settings. We will fix this in Oxygen. Moving out of Neon
> 
> We are now in Photon at the end of M7.  Anything planned for Photon?

We haven't implemented custom DPI in photon. So Moving this out
Comment 8 Christoph Obexer CLA 2018-06-30 12:55:48 EDT
This same issue happens with a scale factor of 2 on Plasma 5.13.1 on openSUSE Tumbleweed. I get 4 equally big segments of the splash screen image and text that appears to be correctly scaled but wrongly positioned (as seen in the attached screenshot already).

IMO this has nothing to do with custom DPI.
Comment 9 Eclipse Genie CLA 2020-11-30 06:56:21 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.