Bug 493147 - Add F1 help documentation for DS Annotations preference page
Summary: Add F1 help documentation for DS Annotations preference page
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Doc (show other bugs)
Version: 4.6   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.6 RC3   Edit
Assignee: Vikas Chandra CLA
QA Contact:
URL:
Whiteboard:
Keywords: Documentation
Depends on:
Blocks:
 
Reported: 2016-05-06 10:32 EDT by Noopur Gupta CLA
Modified: 2016-05-26 03:26 EDT (History)
4 users (show)

See Also:
Lars.Vogel: review+
daniel_megert: review-
markus.kell.r: review+
daniel_megert: review+
Lars.Vogel: review+

Attachments
documentation patch1 (2.51 KB, patch)
2016-05-23 07:16 EDT, Vikas Chandra CLA 		no flags Details | Diff
Patch in pde git (1.08 KB, patch)
2016-05-23 07:17 EDT, Vikas Chandra CLA 		no flags Details | Diff
PDE UI patch (2.31 KB, patch)
2016-05-25 07:00 EDT, Vikas Chandra CLA 		no flags Details | Diff
PDE Doc patch (2.93 KB, patch)
2016-05-25 07:01 EDT, Vikas Chandra CLA 		no flags Details | Diff
PDE UI patch (2.29 KB, patch)
2016-05-25 07:02 EDT, Vikas Chandra CLA 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Noopur Gupta CLA 2016-05-06 10:32:50 EDT 
Go to DS Annotations preference page and press F1. 
There is no documentation available for the preference page.
Comment 1 Vikas Chandra CLA 2016-05-16 08:20:58 EDT 
Peter, can you look at this for 4.6RC2?
Comment 2 Vikas Chandra CLA 2016-05-23 07:16:19 EDT 
Created attachment 261943 [details]
documentation patch1

Patch in platform.common git
Comment 3 Vikas Chandra CLA 2016-05-23 07:17:14 EDT 
Created attachment 261944 [details]
Patch in pde git

Patch in pde.ui.git
Comment 4 Vikas Chandra CLA 2016-05-25 04:09:28 EDT 
Need 3 +1s for the two patches attached. Both patches needs to be applied to see the documentation.
Comment 5 Dani Megert CLA 2016-05-25 05:59:44 EDT 
(In reply to Vikas Chandra from comment #3)
> Created attachment 261944 [details] [diff]
> Patch in pde git
> 
> Patch in pde.ui.git

Please add IHelpContextIds which defines the help context ID.
Comment 6 Dani Megert CLA 2016-05-25 06:04:50 EDT 
(In reply to Vikas Chandra from comment #2)
> Created attachment 261943 [details] [diff]
> documentation patch1


The option "Generate descriptors from annotated sources" should be checked to enable this functionality.

==>

The option 'Generate descriptors from annotated sources' needs to be checked to enable this functionality.


The entries in the build.properties are alphabetically sorted. Please insert the new entry at the correct location.

Copyright is missing in the new file.
Comment 7 Vikas Chandra CLA 2016-05-25 07:00:50 EDT 
Created attachment 261996 [details]
PDE UI patch
Comment 8 Vikas Chandra CLA 2016-05-25 07:01:06 EDT 
Created attachment 261997 [details]
PDE Doc patch
Comment 9 Vikas Chandra CLA 2016-05-25 07:02:35 EDT 
Created attachment 261998 [details]
PDE UI patch
Comment 10 Vikas Chandra CLA 2016-05-25 07:10:42 EDT 
Updated the patch.

Dani can you have a look?
Comment 11 Markus Keller CLA 2016-05-25 10:15:38 EDT 
+1 for RC3.
Comment 12 Dani Megert CLA 2016-05-25 10:24:00 EDT 
(In reply to Vikas Chandra from comment #10)
> Updated the patch.
> 
> Dani can you have a look?

Good, except that the string is not fixed according to comment 6:
should be checked  --> needs to be checked
Comment 13 Lars Vogel CLA 2016-05-25 10:29:55 EDT 
Change looks fine but please use Gerrit in the future in case you expect code reviews.
Comment 15 Vikas Chandra CLA 2016-05-25 11:32:12 EDT 
Lars, will do so in future. Thanks !
Comment 16 Dani Megert CLA 2016-05-26 03:26:31 EDT 
Verified in eclipse-SDK-I20160525-2000-win32-x86_64.