Bug 493146 - Unable to build on darwin
Summary: Unable to build on darwin
Status: RESOLVED FIXED
Alias: None
Product: TCF
Classification: Tools
Component: Agent (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: 1.4   Edit
Assignee: Project Inbox CLA
QA Contact: Eugene Tarassov CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-06 10:21 EDT by Greg Watson CLA
Modified: 2016-05-26 04:31 EDT (History)
1 user (show)

See Also:
eugene: iplog+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Watson CLA 2016-05-06 10:21:04 EDT 
When I try to build the agent on OS X 10.11.4, I get the following error:

system/Darwin/tcf/context-darwin.c:219:26: error: invalid operands to binary expression ('SigSet' (aka 'struct SigSet') and 'int')
    ctx->pending_signals &= ~(1 << signal);

I think this should be replaced with something like:

    sigset_set(ctx->pending_signals, signal, 1);
Comment 1 Greg Watson CLA 2016-05-06 10:21:22 EDT 
Actually:

   sigset_set(&ctx->pending_signals, signal, 1);
Comment 2 Eugene Tarassov CLA 2016-05-06 12:19:36 EDT 
I have committed the change. However, I have to say it might be not enough to get the debugger working on Darwin. Somebody contributed Darwin support long ago, but it was not maintained since then.

Fixed.
Thanks!
Comment 3 Martin Oberhuber CLA 2016-05-10 12:51:29 EDT 
Since this looks like a contribution that came in through bugzilla comment, 
looks like we'll need to set iplog+ on the whole bug - Eugene can you confirm ?
Comment 4 Martin Oberhuber CLA 2016-05-26 04:31:29 EDT 
Setting target milestone for all RESOLVED/FIXED recently to 1.4

Please comment if any fix was actually backported or the target milestone would be incorrect for any other reason.