Bug 493060 - DOT Graph View - DOT to Zest conversion does not properly set sizes in emulated mode.
Summary: DOT Graph View - DOT to Zest conversion does not properly set sizes in emulat...
Status: NEW
Alias: None
Product: GEF
Classification: Tools
Component: GEF DOT (show other bugs)
Version: 0.2.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: gef-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-05 06:50 EDT by Alexander Nyßen CLA
Modified: 2018-11-14 03:49 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Nyßen CLA 2016-05-05 06:50:45 EDT 
When no size is specified in the Dot input (i.e. in emulated mode), Dot2ZestAttributesConverter does not set any Zest size. It should rather use the dot default size (0.75, 0.5) inches and (if layout is different from dot and fixedsize is not set) should extend it to make the label fit.
Comment 1 Alexander Nyßen CLA 2016-05-05 08:03:03 EDT 
Pushed the following change to origin/master:

- Ensured that when no size is given, nodes are resized to the default dot size of (0.75, 0.5) inches. Ensured that when in emulated mode, the label size is taken into consideration.

We still need to ensure image size and margin are taken into consideration as well (when being in emulated mode). In contrast to the Graphviz documentation, even the dot layout algorithm seems to respect the fixed size (and resizes nodes to make the label fit).