Bug 49259 - Task tags starting with TODO don't correctly display their priority in Tasks View
Summary: Task tags starting with TODO don't correctly display their priority in Tasks ...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 2.1.2   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 3.0 M8   Edit
Assignee: Philipe Mulet CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-12-22 01:23 EST by David Beck CLA
Modified: 2004-03-24 09:20 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Beck CLA 2003-12-22 01:23:48 EST 
Task tags defined in Preferences -> Java -> Task Tags that are strings starting 
with TODO and assigned other than Normal priority will not have their 
priorities correctly displayed in the 3rd. Task View column.

To reproduce:

1) Define a task tag in Preferences -> Java -> Task Tags for the string 
TODO_HIGH and assign it High priority.

2) Define an additional task tag similar to step #1 for the string MYHIGHTAG 
and also assign it High priority.

3) Add 2 comment lines to a Java source file, one starting with the TODO_HIGH 
tag and the other starting with the MYHIGHTAG.

4) Note in Tasks view that the High priority icon is displayed for the 
MYHIGHTAG task and no icon (indicating normal) priority is displayed for the 
TODO_HIGH.
Comment 1 Dirk Baeumer CLA 2003-12-26 13:54:14 EST 
Martin, please investigate.
Comment 2 Martin Aeschlimann CLA 2004-02-09 14:19:08 EST 
The task 'TODO_HIGH' gets matched as 'TODO', '_HIGH' already seems to be a part
of the comment.
Seems a bit too limiting. Moving to jdt.core
Comment 3 Philipe Mulet CLA 2004-02-10 09:58:17 EST 
There are 2 bugs actually. In JDT Core, we incorrectly only allow task tags to 
be formed of letters or digits, and thus split it at the '_' character. We 
should use the Java identifiers conventions.

On the colouring side, there is a similar bug which incorrectly highlights the 
TODO portion. 

Martin - Could you please enter a separate bug for the colouring ?
Comment 4 Martin Aeschlimann CLA 2004-02-10 10:48:29 EST 
filed bug 51466 against the Java editor
Comment 5 Philipe Mulet CLA 2004-02-13 18:29:43 EST 
Fixed.
Comment 6 Jerome Lanneluc CLA 2004-03-24 09:20:02 EST 
Verified in I200403240010.