Bug 492483 - Null errors when entering credentials in vendor-neutral Cloud Foundry entry with no URL
Summary: Null errors when entering credentials in vendor-neutral Cloud Foundry entry w...
Status: RESOLVED FIXED
Alias: None
Product: CFT
Classification: ECD
Component: General (show other bugs)
Version: unspecified   Edit
Hardware: PC Mac OS X
: P3 normal
Target Milestone: 1.0 RC1   Edit
Assignee: Elson Yuen CLA
QA Contact:
URL:
Whiteboard:
Keywords: plan
Depends on:
Blocks:
 
Reported: 2016-04-26 15:38 EDT by Nieraj Singh CLA
Modified: 2016-05-05 11:33 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nieraj Singh CLA 2016-04-26 15:38:43 EDT
When initially entering credentials in New Server Wizard and there is no default server URL, null errors are continuously thrown when entering credentials while wizard auto-validation kicks in on each text entry in the credentials widgets. This only happens if there is no URL set. Once a URL is set in manage URL, the errors stop and the user can create a server without issues:


org.eclipse.core.runtime.AssertionFailedException: null argument:
	at org.eclipse.core.runtime.Assert.isNotNull(Assert.java:85)
	at org.eclipse.core.runtime.Assert.isNotNull(Assert.java:73)
	at org.eclipse.cft.server.core.internal.client.SelfSignedStore.<init>(SelfSignedStore.java:55)
	at org.eclipse.cft.server.core.internal.CloudFoundryServer.getSelfSignedCertificate(CloudFoundryServer.java:1405)
	at org.eclipse.cft.server.core.internal.CloudFoundryServer.getSelfSignedCertificate(CloudFoundryServer.java:855)
	at org.eclipse.cft.server.ui.internal.ServerWizardValidator.serverValidation(ServerWizardValidator.java:190)
	at org.eclipse.cft.server.ui.internal.ServerWizardValidator.validate(ServerWizardValidator.java:97)
	at org.eclipse.cft.server.ui.internal.ValidationEventHandler.validate(ValidationEventHandler.java:210)
	at org.eclipse.cft.server.ui.internal.ValidationEventHandler.getValidationEvent(ValidationEventHandler.java:270)
	at org.eclipse.cft.server.ui.internal.ValidationEventHandler.handleChange(ValidationEventHandler.java:132)
	at org.eclipse.cft.server.ui.internal.UIPart.notifyChange(UIPart.java:64)
	at org.eclipse.cft.server.ui.internal.CloudFoundryCredentialsPart.updateUI(CloudFoundryCredentialsPart.java:289)
	at org.eclipse.cft.server.ui.internal.CloudFoundryCredentialsPart$2.modifyText(CloudFoundryCredentialsPart.java:183)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:179)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4245)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1501)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1524)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1509)
	at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1313)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4069)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3695)
	at org.eclipse.jface.window.Window.runEventLoop(Window.java:818)
	at org.eclipse.jface.window.Window.open(Window.java:794)
	at org.eclipse.wst.server.ui.internal.actions.LaunchWizardAction.run(LaunchWizardAction.java:57)
	at org.eclipse.jface.action.Action.runWithEvent(Action.java:473)
	at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:565)
	at org.eclipse.jface.action.ActionContributionItem.lambda$4(ActionContributionItem.java:397)
	at org.eclipse.jface.action.ActionContributionItem$$Lambda$37/1683046409.handleEvent(Unknown Source)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4245)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1501)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1524)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1509)
	at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1313)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4069)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3695)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1118)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1019)
	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:157)
	at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:691)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:604)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:138)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:497)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:670)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:609)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1516)
Comment 1 Elson Yuen CLA 2016-04-29 17:22:44 EDT
While I am testing on the fix on this problem, I also notice that if the user remove the last URL on the list, the URL field is cleared but the validation does not occur, i.e. the validate button is still enable.  I'll fix that as part of this fix as well.
Comment 2 Elson Yuen CLA 2016-05-05 11:33:21 EDT
Code dropped to master