Community
Participate
Working Groups
It would be useful to provide a version of the MVC Logo example packaged as a pure e4 RCP application using e(fx)clipse. A starting point for this is provided at: https://github.com/ctgnz/gef4-rcp This copies the base logo example project, replacing the MvcLogoExample application with an e4 part. The application is bundled with a feature, product and target definition, to comply with the recommended e(fx)clipse project structure. All of the code in the github location complies with the Eclipse Foundation Certificate of Origin.
That looks interesting and I would be very interested in adopting that as an official example. I do not think that the boilerplate projects (feature, product) are actually needed (even if e(fx)clipse recommends them). IMHO it would be best, if we could isolate the e4-specific things into a single org.eclipse.gef4.mvc.examples.logo.e4 plug-in, which could be used as an alternative to the org.eclipse.gef4.examples.logo.ui to demonstrate the native e4 integration. Besides the standalone (org.eclipse.gef4.mvc.logo plug-in) and the web integration, we would then have an pure e4 and a 3.x compatibility layer integration in the context of Eclipse. We would have to integrate it into the GEF4 releng infrastructure, and it would of course have to consume the GEF4 target (which we would have to extend if required; IMHO it should already provide all the necessary stuff). Would you be willing to support that? It would require that you either produce a respective patch, or fork the repository on GitHub and create a pull request (which is currently less recommended, because the GitHub mirror is only synchronized from time to time; we have decided to move our repo to GitHub after M7 is completed, which would make that alternative easier, but up to then, a patch is the easiest alternative).
Fair enough. I will create another version as a single bundle called org.eclipse.gef4.mvc.examples.logo.e4. I'll leave my existing example on my GitHub, as I think it's a fairly instructive example for those looking to produce an actual product, but for the purposes of an example a single bundle will do. I may need some help with the mechanics of getting a patch, as I am still pretty new to git and GitHub.
Okay, I have committed the logo.e4 bundle into my GitHub. This is even more minimal - it depends on the examples logo bundle, so the only code in it is the e4 part. How do I create a patch from a new project?
(In reply to Colin Sharples from comment #3) > Okay, I have committed the logo.e4 bundle into my GitHub. This is even more > minimal - it depends on the examples logo bundle, so the only code in it is > the e4 part. > > How do I create a patch from a new project? I have documented the necessary steps in the GEF contributor guide (https://wiki.eclipse.org/GEF/Contributor_Guide). You should set up the GEF4 sources locally, which will also allow you to properly integrate it with the releng infrastructure.
