Community
Participate
Working Groups
Consider a situation with two changed unstaged files, A.java and B.java. Until recently the Commit command invoked from the context menu of A.java displayed a Commit dialog with A.java checked and B.java unchecked. Now is brings up the Git Staging view, but both A.java and B.java are listed as unstaged. The user has to explicitly add A.java to index before creating the commit. The Commit command invoked from a context menu of a file should automatically stage the file. It should probably also unstage all files that were staged previously but were not selected when Commit was invoked.
(In reply to Sergey Prigogin from comment #0) > Consider a situation with two changed unstaged files, A.java and B.java. > Until recently the Commit command invoked from the context menu of A.java > displayed a Commit dialog with A.java checked and B.java unchecked. Now is > brings up the Git Staging view, but both A.java and B.java are listed as > unstaged. The user has to explicitly add A.java to index before creating the > commit. you can still use the Commit Dialog by changing the preference "Team > Git > Committing > Use Staging View to commit instead of Commit Dialog" > The Commit command invoked from a context menu of a file should > automatically stage the file. It should probably also unstage all files that > were staged previously but were not selected when Commit was invoked. When clicking "Commit..." the staging view should be shown and all unstaged files should be pre-selected. I didn't add more magic since I wasn't sure which magic the majority of our users would expect. I think it could make sense to auto-stage the files selected when clicking "Commit...", but I think I would not want the not-selected files to be auto-unstaged since the staging view is non-modal and I always use it in an incremental way which isn't possible with the commit dialog, well since that's modal. Of course we could add more options to let users choose the behaviour they want.
