Community
Participate
Working Groups
Created attachment 260328 [details] Win_EclipseSplash_at_150_Zoom With Eclipse Neon I-build: I20160313-2000 and onwards build which contains SWT HighDpi autoScale feature.(SWT bug 479614) Splash Screen is getting cropped when the OS zoom setting is 150%/200% Refer attached screen shot. Note:- Same behavior is seen in GTK as well.
Please note that on Windows 10, 150% OS zoom the splash screen "shrinks" after showing the progress bar *without* the HiDPI patch since 4.6 beginning, so that this bug is probably related to the same buggy code.
(In reply to Andrey Loskutov from comment #1) > Please note that on Windows 10, 150% OS zoom the splash screen "shrinks" > after showing the progress bar *without* the HiDPI patch since 4.6 > beginning, so that this bug is probably related to the same buggy code. Hi Andrey, HighDPI feature bug 479614 changes are recently released to M6 build. Can you please confirm if you still notice splash screen shrinking problem with latest 4.6 M6 I-build: I20160313-2000 or onwards builds @ Win10, 150% OS zoom ? Thanks.
Created attachment 260355 [details] win 10 splash at 150 % (In reply to Niraj Modi from comment #2) > (In reply to Andrey Loskutov from comment #1) > > Please note that on Windows 10, 150% OS zoom the splash screen "shrinks" > > after showing the progress bar *without* the HiDPI patch since 4.6 > > beginning, so that this bug is probably related to the same buggy code. > > Hi Andrey, > HighDPI feature bug 479614 changes are recently released to M6 build. > Can you please confirm if you still notice splash screen shrinking problem > with latest 4.6 M6 I-build: I20160313-2000 or onwards builds @ Win10, 150% > OS zoom ? > Thanks. I see now both now on I20160316-0800 / Win 10 64 bit / 150% OS zoom: initially, before the progress bar appears, the splash is sized and scaled properly. Then the splash size shrinks (regression in 4.6 but before HiDPI) AND the content is drawn "zoomed" (introduced with HiDPI). I've attached screenshot how it looks like.
please refer to Bug 488910 for GTK. There is a gerrit patch already available for that
New Gerrit change created: https://git.eclipse.org/r/70465
(In reply to Eclipse Genie from comment #5) > New Gerrit change created: https://git.eclipse.org/r/70465 Attempted a possible fix in Platform UI code(may be it applies to both Win32 and GTK)
(In reply to Niraj Modi from comment #6) > (In reply to Eclipse Genie from comment #5) > > New Gerrit change created: https://git.eclipse.org/r/70465 > > Attempted a possible fix in Platform UI code(may be it applies to both Win32 > and GTK) With this change we donot scale the splash screen at all. This is resulting in the messages on the splash screen to get cropped. I donot think this is correct. We have to scale the splash screen as well. At higher zoom levels the splash screen becomes very small
(In reply to Sravan Kumar Lakkimsetti from comment #7) > (In reply to Niraj Modi from comment #6) > > (In reply to Eclipse Genie from comment #5) > > > New Gerrit change created: https://git.eclipse.org/r/70465 > > > > Attempted a possible fix in Platform UI code(may be it applies to both Win32 > > and GTK) > > With this change we donot scale the splash screen at all. Yes, because autoScale of splash is happening in launcher(at-least on Win7) and the coordinate information passed over by Launcher process via System properties are in Pixels, so this patch converts it to Points before setting it on an SWT control. Also I am using the new HighDPI Image constructor to load the Splash Screen as-is. This solves the splash-screen cropping/double scaling problem. Will check with Markus if there's a better alternate-fix. > This is resulting in the messages on the splash screen to get cropped. > I donot think this is correct. Please refer latest Gerrit patch it fixes the message cropping/overlapping problem. > We have to scale the splash screen as well. > > At higher zoom levels the splash screen becomes very small I assume you tested the patch in Self-hosted mode, which bypasses the launcher process and directly instantiates JVM process for Eclipse Wrokbench, hence you will always see splash screen of 100% zoom size in self-hosted mode. IMHO Stand alone Eclipse with this fix should look fine now.
New Gerrit change created: https://git.eclipse.org/r/71041
(In reply to Eclipse Genie from comment #9) > New Gerrit change created: https://git.eclipse.org/r/71041 Attempted a equivalent fix in Windows Launcher now as UI patch in comment 5 works only for Windows, and partially on GTK.
Gerrit change https://git.eclipse.org/r/71041 was merged to [master]. Commit: http://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?id=9fa023ca5c273cb706c1976b89805d6faed48b9a
binaries have been recompiled and committed through https://git.eclipse.org/c/equinox/rt.equinox.binaries.git/commit/?id=90e02f5044874dbb5bd2f935d7560f9140786af0
Verified on Win7 with Build id: I20160425-1300
