Comment 1 Pierre-Charles David 2016-03-09 11:08:06 EST

One concrete example of bug triggered when the Model Explorer is enabled as input source. The scenarion is using the default rules for properties views, but it should be reproducible with user-specified rules.

1. Open a session with a least one diagram (or other representation) available.
2. Expand the semantic model in the Model Explorer, and select the representation. Two tabs appear in the properties view: "General" (contributed b the default rules) and "Documentation" (legacy).
3. Select the "Documentation" tab => NPE

java.lang.NullPointerException
	at org.eclipse.sirius.editor.properties.sections.common.AbstractViewpointPropertySection.getDescriptors(AbstractViewpointPropertySection.java:198)
	at org.eclipse.sirius.editor.properties.sections.common.AbstractViewpointPropertySection.getPropertyDescriptor(AbstractViewpointPropertySection.java:212)
	at org.eclipse.sirius.editor.properties.sections.common.AbstractMultilinePropertySection.getLabelText(AbstractMultilinePropertySection.java:201)
	at org.eclipse.sirius.editor.properties.sections.description.documentedelement.DocumentedElementDocumentationPropertySection.getLabelText(DocumentedElementDocumentationPropertySection.java:58)
	at org.eclipse.sirius.editor.properties.sections.common.AbstractMultilinePropertySection.setInput(AbstractMultilinePropertySection.java:104)
	at org.eclipse.eef.properties.ui.legacy.internal.legacy2eef.EEFLegacySection.setInput(EEFLegacySection.java:151)
	at org.eclipse.eef.properties.ui.api.EEFTabContents$2.run(EEFTabContents.java:117)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:50)
	at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:173)
	at org.eclipse.eef.properties.ui.api.EEFTabContents.setInput(EEFTabContents.java:120)
	at org.eclipse.eef.properties.ui.api.EEFTabbedPropertySheetPage.processSelectionChanged(EEFTabbedPropertySheetPage.java:507)
	at org.eclipse.eef.properties.ui.api.EEFTabbedPropertySheetPage.access$0(EEFTabbedPropertySheetPage.java:482)
	at org.eclipse.eef.properties.ui.api.EEFTabbedPropertySheetPage$1.selectionChanged(EEFTabbedPropertySheetPage.java:239)
	at org.eclipse.eef.properties.ui.internal.page.EEFTabbedPropertyViewer.fireSelectionChanged(EEFTabbedPropertyViewer.java:117)
	at org.eclipse.eef.properties.ui.internal.page.EEFTabbedPropertyViewer.access$1(EEFTabbedPropertyViewer.java:115)
	at org.eclipse.eef.properties.ui.internal.page.EEFTabbedPropertyViewer$1.widgetSelected(EEFTabbedPropertyViewer.java:99)

Comment 2 Eclipse Genie 2016-08-31 05:42:26 EDT

New Gerrit change created: https://git.eclipse.org/r/80115

Comment 3 Eclipse Genie 2016-09-02 05:19:57 EDT

Gerrit change https://git.eclipse.org/r/80115 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=da6744ff41cfc9ce02957fd74e8a80b0486116ad

Comment 4 Pierre-Charles David 2016-09-08 11:51:48 EDT

The "Model Explorer" input has been enabled, and none of the many bugs we had with Sirius 4.0 have been reproduced. Probably because of the improvements on the EEF side regarding compatibility with legacy tabs.

I'm keeping this one opened, in case we see bugs while playing with it, and because there is no automated test yet (marking "needtest" too), but for now no known issue/task remains.

Comment 5 Eclipse Genie 2016-09-15 15:25:16 EDT

Gerrit change https://git.eclipse.org/r/80496 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=300c4e8a845d4bd3b0a146eb054e28a73b340016

Comment 6 Pierre-Charles David 2016-10-04 08:45:33 EDT

Fixed. Enabling this makes https://bugs.eclipse.org/bugs/show_bug.cgi?id=500894 even more obvious and easy to trigger than it was before, but that is a separate issue.

Comment 7 Pierre-Charles David 2016-10-18 11:08:36 EDT

Available in Sirius 4.1.0, see https://wiki.eclipse.org/Sirius/4.1.0 for details.