Bug 488055 - Need tests for new declarative service usage
Summary: Need tests for new declarative service usage
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 4.6 M6   Edit
Assignee: Peter Nehrer CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 376950 411404 475230 475241 488075
Blocks:
  Show dependency tree
 
Reported: 2016-02-18 14:40 EST by Lars Vogel CLA
Modified: 2016-03-16 02:28 EDT (History)
20 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2016-02-18 14:40:43 EST 
+++ This bug was initially created as a clone of Bug #376950 +++

We should add tests for the OSGi ds 1.2 spec contribute by Bug 376950.
Comment 1 Eclipse Genie CLA 2016-02-22 16:09:32 EST 
New Gerrit change created: https://git.eclipse.org/r/67094
Comment 2 Vikas Chandra CLA 2016-03-02 06:17:50 EST 
I see this warning in ds.annotations.test1

An entry for OSGI-INF/ is required in bin.includes

Is this expected? 

Also this needs to be in for M6.
Comment 3 Peter Nehrer CLA 2016-03-02 07:40:11 EST 
(In reply to Vikas Chandra from comment #2)
> I see this warning in ds.annotations.test1
> 
> An entry for OSGI-INF/ is required in bin.includes
> 
> Is this expected? 

Yes, this is expected and not related to this contribution.

Also, I'm adding test cases for error checking so there'll be a lot more warnings and even errors in the test projects.
Comment 4 Vikas Chandra CLA 2016-03-03 01:40:24 EST 
Thanks Peter. I will look at these junits for M6.

I think it will be good to have an user level testing scenarios ( in same lines as one below)

https://wiki.eclipse.org/PDE/API_Tools/Testing#Annotations

The idea there should be to cover most of the important messages in
org.eclipse.pde.ds.annotations\src\org\eclipse\pde\ds\internal\annotations\messages.properties
Comment 5 Lars Vogel CLA 2016-03-03 02:02:53 EST 
Vikas, can you open a new bug for the user testing stories? "My" bug was opened for software tests.
Comment 6 Vikas Chandra CLA 2016-03-03 04:33:25 EST 
Created Bug 488925
Comment 7 Vikas Chandra CLA 2016-03-04 02:12:09 EST 
I think we can commit these tests and later add on further tests.
Comment 8 Vikas Chandra CLA 2016-03-07 03:10:43 EST 
Peter, are you planning to add further tests for 4.6 M6?
Comment 9 Peter Nehrer CLA 2016-03-07 11:03:04 EST 
No, not for M6.
Comment 10 Vikas Chandra CLA 2016-03-07 13:56:25 EST 
Ok. I will commit the tests on this bug tomorrow.
Comment 12 Vikas Chandra CLA 2016-03-08 23:43:17 EST 
Thanks Peter
Comment 13 Vikas Chandra CLA 2016-03-08 23:46:56 EST 
Opened Bug 489258 - Further tests for new declarative service usage for 4.6M7
Comment 14 Vikas Chandra CLA 2016-03-16 02:28:05 EDT 
org.eclipse.pde.ds.annotations.tests is now in pde.ui.git repository