Community
Participate
Working Groups
Created attachment 259696 [details] orion-editor-line-numbers.png The line numbers in the editor do not have enough color contrast to meet the WCAG 2.0 AA standard. Their current color is silver on white, or rgb(192, 192, 192) on rgb(255, 255, 255). In order to be WCAG 2.0 AA compliant, the minimum color the numbers need to be is rgb(118, 118, 118) (aka #767676). This "slightly darker silver" color looks very similar to the current silver. In the attached screen snapshot, the numbers 5 and 7 have been changed to be WCAG 2.0 AA compliant.
One of only 2 remaining problems before we can say that the Orion Editor passes WCAG 2.0 AA for color contrast.
Please fix it. Get SSQ to approve the look and paste the image back here (or just release it when the code freeze is over and tell me).
How do I clear the settings cache on the server? I can't figure out how to test my changes - the old colors always win. Anton, how did you force changes out to everyone after changing a color in a default theme (i.e. Prospecto)? You must know of a nice hack for this? :)
You need to increment THEMES_VERSION in ThemeVersion.js to force everyone to get the new theme definition.
Thank-you!! I was banging my head against a wall on that one. That fixes it nicely. Releasing to Gerrit - SSQ please have a look when it comes through. Note that it's important that the demo have the new contrast color also. Note that the (old?) color #CCCCCC does not have enough contrast either.
New Gerrit change created: https://git.eclipse.org/r/67905
Gerrit change https://git.eclipse.org/r/67905 was merged to [master]. Commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=10c7e6406892859d2e6585748704237cc289dda6
Fixed with commit in comment 7.
