Bug 487473 - [search] Search results can't be opened in new tabs
Summary: [search] Search results can't be opened in new tabs
Status: REOPENED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Client (show other bugs)
Version: 10.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: libing wang CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
: 490938 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-02-08 15:59 EST by Curtis Windatt CLA
Modified: 2018-04-09 10:50 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Windatt CLA 2016-02-08 15:59:50 EST 
1) Run a search (all references or find in file)
2) Click on a result - file opens correctly
3) Right click on a result and press 'Open in new tab'
Result:
New tab has about:blank

Same result for middle clicking and ctrl+click, the url of the link is not set (we listen for the click event).
Comment 1 libing wang CLA 2016-02-08 16:05:12 EST 
To fix bug 483046, we had to dynamically generate the href for all the hit links. We add a click listener and takes care of CTRL or CMD key properties in the event so that we can simulate the open in a new tab. But we are losing the right click on a link from the browser.
we may end up regenerating all the hrefs responding to  "annotation chnaged" event
Comment 2 Carolyn MacLeod CLA 2016-02-08 18:25:03 EST 
Please also test with Ctrl+Enter when link has keyboard focus.
Comment 3 Curtis Windatt CLA 2016-04-04 11:18:21 EDT 
*** Bug 490938 has been marked as a duplicate of this bug. ***
Comment 4 Michael Rennie CLA 2017-01-10 15:44:14 EST 
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:

https://dev.eclipse.org/mhonarc/lists/orion-dev/msg04002.html
Comment 5 Grant Gayed CLA 2017-01-11 10:26:00 EST 
Reopening, would still like to see this addressed some day.
Comment 6 Michael Rennie CLA 2018-04-09 09:39:57 EDT 
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. 

For more details see: https://dev.eclipse.org/mhonarc/lists/orion-dev/msg04114.html
Comment 7 Grant Gayed CLA 2018-04-09 10:50:36 EDT 
Still think this would be valuable, so reopening and have added keyword 'triaged'.