Community
Participate
Working Groups
If a VStack container A contains a list container B the border of B is not considered properly. Thus list entries start directly at the border of A without any spacing. Current workaround is introducing a Free form container X containing A. This leads to other problems though, as the alignment and width of B is not done automatically anymore. So it would be great if the border handling of containers inside compartments could be considered.
Created attachment 259631 [details] Margin in sample with ecore. The issue can easily be reproduced with any existing diagram containing list compartments: . get the compartiment test case /org.eclipse.sirius.tests.junit/data/unit/compartments . Simply select a diagram element . Select the "Style" property tab . Set the label alignment to Left . Set the Show icon property to false > There is no margin between the text and the border in case of compartiments. Compare the result with the Class list in EcoreTools. The rendering is nearly ok with an ecore model as semantic model because ecore icons have a "margin", but the issue is visible as soon as you hide the icon. I think Axel had "full" icon with non transparent pixel anywhere in the 16x16 icon files. So he directly see the issue.
Also if the icons have some transparent margin the issue becomes visible if you want a wider margin (in my case 12-15 pixels).
Created attachment 259632 [details] Margin on standard list container I have attached an image taken from EcoreTools + left alignment and show icon set to false. It shows that the list items have a margin. But we might improve the list label rendering with a small margin between the label and the border.
Thanks for your detailed bug report. We have reproduced this issue and we consider it as valid. Nevertheless, we have currently not planned to work on it in the following releases.
It seems we should add some margin/insets between the border and the label of DNodeList/DNodeContainer. Same idea for list items in compartiments.
Created attachment 259633 [details] Margin issues
Created attachment 259634 [details] Base screenshot
(In reply to Maxime Porhel from comment #5) > It seems we should add some margin/insets between the border and the label > of DNodeList/DNodeContainer. Same idea for list items in compartiments. There is two different issues: . margin for label of DNodeContainer/DNodeList (as container, list or region): this en improvement as the label margin has always be like this, see Bug . margin for list items in regions/compartiments, it seems that the border of the list region viewport is not well configured compared to standard lists (see attachments). This issue will now deals only with the list items margin. The container/list/region label will be treated in Bug 487858.
Created attachment 259952 [details] Margin issues
New Gerrit change created: https://git.eclipse.org/r/67530
Gerrit change https://git.eclipse.org/r/66632 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=c4bd9ee3661f045c8ad7368f2f6c20e4344ec7e2
Gerrit change https://git.eclipse.org/r/67530 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=fe06287f17d522b290e631d8025340de0e47e4b4
List items now have the same margin whether they are contained in simple list or in a compartmentalized list.
Verified on Sirius 4.0.0.RC1
Available in Sirius 4.0.0.
