Bug 48736 - [content assist][organize imports][open type] "Type Filters" should allow to decrease priority
Summary: [content assist][organize imports][open type] "Type Filters" should allow to ...
Status: ASSIGNED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: JDT-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: fix candidate
Keywords:
: 308281 (view as bug list)
Depends on:
Blocks: 323941
  Show dependency tree
 
Reported: 2003-12-15 06:35 EST by Markus Keller CLA
Modified: 2010-08-30 12:34 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2003-12-15 06:35:52 EST
'Preferences > Java > Type Filters' should not completely hide matching types
from the Open Type dialog.

Matching types should only get a lower priority than the other types, so that
the first qualifier choice is always a non-filtered type if possible.
Comment 1 Dirk Baeumer CLA 2004-05-21 12:20:43 EDT
Nor for 3.0.
Comment 2 Markus Keller CLA 2007-03-16 05:52:49 EDT
'Lower priority instead of filtering' would also have to apply for content assist.
Comment 3 Markus Keller CLA 2009-03-13 06:33:54 EDT
We should just give unchecked entries from the Type Filters preferences a lower priority.
Comment 4 Markus Keller CLA 2009-03-13 06:49:50 EDT
> We should just give unchecked entries from the Type Filters preferences a lower
> priority.

The user should be able to configure this new interpretation of unchecked type filters e.g. via a checkbox "Reduce priority of types matching unselected filters".
Comment 5 Markus Keller CLA 2010-04-07 06:49:25 EDT
*** Bug 308281 has been marked as a duplicate of this bug. ***
Comment 6 Markus Keller CLA 2010-04-07 07:18:46 EDT
We should add priorities to the Type Filters feature in Content Assist, Organize Imports, and Open Type.

- types that match checked filters should be filtered
- types that match unchecked filters should have lower priority (should be sorted after other types with the same name)

Types that match unchecked filters could also be presented in the order of the filters. For that, the user would need to reorder the entries in the Type Filters dialog.
Comment 7 Jason CLA 2010-04-07 14:48:15 EDT
Should I put this in a different enhancement issue?

--

There should be a save-actions-auto-import-settings area where I could specify classes which I would want it to choose automatically.

Example:

1. I go to this settings area and I say that I want java.util.List to be the dominant List.

2. I type into eclipse:

public static void main(String[] args){
    List<String> list = new ArrayList<String>();
    list.add("I hate having to choose which imports I want when I choose the same ones every time!");
}

3. I then press "CTRL-S" to save.

Now, when I do the above steps on my computer, it does what I want because I type-filtered out java.awt.List, but if I explicitly type "List" + "CTRL+SPACE", I want java.awt.List to still be available (as a lower ranked option).  With type filters right now, it is all or nothing.
Comment 8 Dani Megert CLA 2010-04-08 02:08:23 EDT
I see: you'd like the filters to work for Organize Imports but for content assist you want to see all proposals but the filtered ones with lower prio. No need to open a separate bug for that. Once we tackle this bug we'll decide how much flexibility we want to add.