Bug 487053 - Breakpoint's "Ignore count" value changes when the breakpoint is hit
Summary: Breakpoint's "Ignore count" value changes when the breakpoint is hit
Status: NEW
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf-gdb (show other bugs)
Version: 8.8.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-02 21:31 EST by Nobody - feel free to take it CLA
Modified: 2020-09-04 15:22 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nobody - feel free to take it CLA 2016-02-02 21:31:57 EST 

    


    


      



        
          Comment 1
        

        
          Nobody - feel free to take it CLA

        

        
        

        
          2016-02-02 21:58:45 EST
        

      






Breakpoint's ignore count gets decreased by 1 every time the breakpoint is hit. This is not the expected behavior, the ignore count should not change.

    


    


      



        
          Comment 2
        

        
          Marc Khouzam CLA

        

        
        

        
          2016-02-03 09:42:18 EST
        

      






Where do you see it decreased?  My guess is that GDB indicates the decrease to indicate how many more ignores will be done.

I'm not sure when that count should go back to it's original value?  For a new session at least.  Maybe also when disabled then re-enabled?  Maybe... maybe not...

    


    


      



        
          Comment 3
        

        
          Nobody - feel free to take it CLA

        

        
        

        
          2016-02-03 10:39:46 EST
        

      






(In reply to Marc Khouzam from comment #2)
> Where do you see it decreased?  My guess is that GDB indicates the decrease
> to indicate how many more ignores will be done.
>

In the Breakpoints view. You're right, it is updated when a "breakpoint-modified" event occurs.
 
> I'm not sure when that count should go back to it's original value?  For a
> new session at least.  Maybe also when disabled then re-enabled?  Maybe...
> maybe not...

We just shouldn't change the "ignore count" value in the platform breakpoint. It's bad when we have two running sessions with the same breakpoint set in both. In this case the "ignore count" decreases every time the breakpoint is hit in either session. This is definitely not the expected behavior.

Showing the hit count is a good idea but it should a part of the new Breakpoints view that would show target breakpoints as children of platform breakpoints. At least, that is my understanding.

    


    


      



        
          Comment 4
        

        
          Marc Khouzam CLA

        

        
        

        
          2016-02-03 10:43:17 EST
        

      






(In reply to Mikhail Khodjaiants from comment #3)

> We just shouldn't change the "ignore count" value in the platform
> breakpoint. It's bad when we have two running sessions with the same
> breakpoint set in both. In this case the "ignore count" decreases every time
> the breakpoint is hit in either session. This is definitely not the expected
> behavior.
> 
> Showing the hit count is a good idea but it should a part of the new
> Breakpoints view that would show target breakpoints as children of platform
> breakpoints. At least, that is my understanding.

Right, we have a conflict between ignore count and hit count.
We really need to show target breakpoints for this to work properly.