Bug 486731 - Settings page siteActionsArea id is not unique
Summary: Settings page siteActionsArea id is not unique
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Client (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 11.0   Edit
Assignee: Carolyn MacLeod CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2016-01-28 10:40 EST by Carolyn MacLeod CLA
Modified: 2016-01-28 12:16 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carolyn MacLeod CLA 2016-01-28 10:40:05 EST 
An element's ID must be unique in the DOM.
On the Settings page, the siteActionsArea id is not unique.
Comment 1 Carolyn MacLeod CLA 2016-01-28 12:16:42 EST 
The id of a parent of pushbuttons is not used by the command registry.
So to fix this id-not-unique bug, there are 2 choices:
1) delete the id altogether
2) invent a unique name, which can easily be done with:
	actionsArea.id = "siteActionsArea" + itemName; //$NON-NLS-0$

I decided to go with option 1 and delete the id, because if the id isn't being used, seems to me there's no point in having one.

Fixed with:
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=c3e7f0accdc9e38f4376ca4a8ef6d53db6175be1