Bug 486341 - Improve dark theme for JavaScript Editor + Content assist + Occurrence
Summary: Improve dark theme for JavaScript Editor + Content assist + Occurrence
Status: RESOLVED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: General (show other bugs)
Version: 3.7.1   Edit
Hardware: All All
: P3 normal with 1 vote (vote)
Target Milestone: 3.8 M7   Edit
Assignee: Angelo ZERR CLA
QA Contact: Victor Rubezhny CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-22 06:45 EST by Angelo ZERR CLA
Modified: 2016-03-30 14:33 EDT (History)
3 users (show)

See Also:

Attachments
Current dark theme (left) VS proposed dark theme (right) (35.79 KB, image/png)
2016-01-22 06:49 EST, Angelo ZERR CLA 		no flags Details
Dark theme for Content Assist (109.81 KB, image/png)
2016-01-22 07:00 EST, Angelo ZERR CLA 		no flags Details
Dark theme with occurrence (5.94 KB, image/png)
2016-01-22 07:05 EST, Angelo ZERR CLA 		no flags Details
Dark theme with hyperlink (16.69 KB, image/png)
2016-01-26 03:46 EST, Angelo ZERR CLA 		no flags Details
Dark theme problem with backround selection content assist in Widows 64 bits OS (53.80 KB, image/png)
2016-01-26 05:52 EST, Angelo ZERR CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Angelo ZERR CLA 2016-01-22 06:45:18 EST 
I find that dark theme for JavaScript Editor is not perfect:

 * coloration should use more "smmoth" color and not "flashy" color (like the green and red).
 * content assist should be styled with dark theme.
 * popup information of the content assist/ hover  "smmoth" color
 * occurrence should use  "smmoth" color

I will provide screenshot to show you what I mean and a patch for those improvements.
Comment 1 Angelo ZERR CLA 2016-01-22 06:49:48 EST 
Created attachment 259328 [details]
Current dark theme (left) VS proposed dark theme (right)

Here a screenshot with my proposition to use not "flashy" color. It looks like VSCode.
Comment 2 Angelo ZERR CLA 2016-01-22 07:00:46 EST 
Created attachment 259329 [details]
Dark theme for Content Assist

Here a scrrenshot about content assist with template + inference with current dark theme (left) and my prposed theme (right).

I find it's not perfect because of the highlight of the compeltion item (I don(t know how to fix that?)
Comment 3 Angelo ZERR CLA 2016-01-22 07:05:02 EST 
Created attachment 259330 [details]
Dark theme with occurrence

Here a screenshot with occurrence (on the lft current dark theme), on the right my proposition.

There is a blue color on the left of the editor, do you know how we coudl remove it?
Comment 4 Angelo ZERR CLA 2016-01-22 07:06:18 EST 
I have added 3 screenshots to show you my proposition. If you like it, I will create a gerrit patch. If you prefer some changes, tell me.

I'm waiting for your answer to create a gerrit patch.

Regard's Angelo
Comment 5 Eclipse Genie CLA 2016-01-22 15:31:48 EST 
New Gerrit change created: https://git.eclipse.org/r/65023
Comment 6 Angelo ZERR CLA 2016-01-26 03:46:56 EST 
Created attachment 259374 [details]
Dark theme with hyperlink

Here a screenshot which styles link with orange.
Comment 7 Angelo ZERR CLA 2016-01-26 05:52:11 EST 
Created attachment 259380 [details]
Dark theme problem with backround selection content assist in Widows 64 bits OS

If someone have an idea, I would like to style backround selection content assist in Widows 64 bits OS. Any suggestion are welcome!
Comment 8 Angelo ZERR CLA 2016-01-28 05:27:58 EST 
For the problem with completion selection background, it seems that it's not possible today, but I think we could emulate it. See my comment at https://bugs.eclipse.org/bugs/show_bug.cgi?id=483225#c1 (Hope one day it will implement).
Comment 9 Eclipse Genie CLA 2016-02-03 02:56:35 EST 
New Gerrit change created: https://git.eclipse.org/r/65755
Comment 10 Angelo ZERR CLA 2016-02-04 08:38:42 EST 
Is there any chance to accept this patch? I would like to do the same thing for HTML, CSS, XML editors. Hope Neon will able to improve dark theme for WTP content assist.

Tell me if you need I must change something. Thanks!