Community
Participate
Working Groups
Created attachment 259294 [details] Mat analysis My English is pool,and I will describe the bug as clearly as possible. Thank you first. During the performance test of our product in IDE,I found the memory increase over 100MB and never recovery after times of FullGC. Then I dump the Java heap,and found that an instance of org.eclipse.xtext.builder.impl.QueuedBuildData contains 26000 instances of org.eclipse.xtext.resource.impl.ChangedResourceDescriptionDelta ,which retain memory over 90MB.(See the attachment.) I tried to analyse the problem,fortunately I found when a java file is changed, JavaChangeQueueFiller will add some deltas: public void elementChanged(ElementChangedEvent event) { List<Delta> deltas = deltaConverter.convert(event.getDelta()); if (deltas != null && !deltas.isEmpty()) { queue.queueChanges(deltas); } } and the deltas well never be removed unless the project is deleted,which results in the problem. How can I resolved the problem.Thanks.
Hmmm, queued deltas should be removed by the Xtext build (ClusteringBuilderState). Did you turn off "Build automatically"?
(In reply to Jan Koehnlein from comment #1) > Hmmm, queued deltas should be removed by the Xtext build > (ClusteringBuilderState). Did you turn off "Build automatically"? If you mean the "Project->Build Automatically" ,no , I keep it selected. Other world, my projects don't have the nature of XtextNature("org.eclipse.xtext.ui.shared.xtextNature").Will the ClusteringBuilderState work then.Thanks.
No, the builder won't run on projects without that nature. We should analyse whether we fill the queue on projects without that nature or when auto-build is swithed off.
(In reply to Jan Koehnlein from comment #3) > No, the builder won't run on projects without that nature. > > We should analyse whether we fill the queue on projects without that nature > or when auto-build is swithed off. In my opinion, JavaChangeQueueFiller should not fill the queue on projects without that nature,so I modify the method elementChanged on my local patch: public void elementChanged(ElementChangedEvent event) { IResourceDelta[] resourceDeltas = event.getDelta().getResourceDeltas(); if(resourceDeltas != null && resourceDeltas.length > 0){ IResourceDelta resourceDelta = resourceDeltas[0]; IResource resource = resourceDelta.getResource(); if(resource instanceof IProject){ //if the project is invalid,return derectly. if(!XtextProjectHelper.hasNature((IProject)resource)) return; } } List<Delta> deltas = deltaConverter.convert(event.getDelta()); if (deltas != null && !deltas.isEmpty()) { queue.queueChanges(deltas); } } Then ,the question comes that, will it result in any problem in other situations? Thanks.
see https://github.com/eclipse/xtext-eclipse/issues/70 as well
