Comment 1 Laurent Goubet 2016-01-29 05:19:40 EST

I think we should simply ignore all messages from oclAsType if at least one possibility is correct. For example,

car.eContainer().oclAsType(Garage)

will _never_ validate without errors. As long as Ecore is registered as a package in the environment, "EAnnotation.reference" is a reference that can hold any EObject, so EAnnotation will be seen as a potential eContainer for our car, and of course EAnnotation cannot be cast (oclAsType) into Garage.

However, the user uses "oclAsType" exactly because he knows (or think he knows) what he's doing. We are to assume that he knows the container of his car is a garage, and the validation shouldn't return any error : there exists one possible case in which the cast won't fail.

Comment 2 Yvan Lussaud 2016-02-01 05:40:32 EST

This is correct but a bit trickier than it sounds. Indeed the validation of a service is called many time with different types (different combination can also match different services) so to cope with that I introduced the IService.validateAllType() method. But I called it in the inner validation loop ValidationServices.callType(). At first it seems to work but on some case upper loops already start to trigget many times ValidationServices.callType() leading to many call to IService.validateAllType()... It's no what we want as it could trigger this issue.

What we need to do is move the IService.validateAllType() call to AstValidator.caseCall() to make sure we call is once per call. Due to other review I suggest to delay this fix after we merge:

https://git.eclipse.org/r/65281
https://git.eclipse.org/r/65473

By the way my fist comment is all wrong... Laurent your comment is right but this looks like it's already done at the service level.

Comment 3 Eclipse Genie 2016-02-01 05:55:56 EST

New Gerrit change created: https://git.eclipse.org/r/65546

Comment 4 Yvan Lussaud 2016-02-02 08:59:24 EST

*** Bug 486046 has been marked as a duplicate of this bug. ***

Comment 5 Eclipse Genie 2016-02-09 03:57:35 EST

Gerrit change https://git.eclipse.org/r/65546 was merged to [master].
Commit: http://git.eclipse.org/c/acceleo/org.eclipse.acceleo.git/commit/?id=c372379313413bdf4eda977649d1b4ce38958590

Comment 6 Laurent Goubet 2016-04-20 06:02:44 EDT

*** Bug 483377 has been marked as a duplicate of this bug. ***