Bug 485425 - ProximityMatcher should not use order for unordered containment references
Summary: ProximityMatcher should not use order for unordered containment references
Status: UNCONFIRMED
Alias: None
Product: EMFCompare
Classification: Modeling
Component: Core (show other bugs)
Version: 3.1.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: EMF Compare CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-08 09:41 EST by Rolf Theunissen CLA
Modified: 2020-06-11 12:51 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rolf Theunissen CLA 2016-01-08 09:41:06 EST
Matching of not unordered containment references should use Set-semantics. Currently the ProximityMatcher looks at the position of an EObject in its containment feature to determine the match. In case of unordered containment features the position should be ignored.

At least the feature-filter and measureDifferences should be fixed.
Comment 1 Emi Su CLA 2016-06-03 03:38:06 EDT
(In reply to Rolf Theunissen from comment #0)
> Matching of not unordered containment references should use Set-semantics.
> Currently the ProximityMatcher looks at the position of an EObject in its
> containment feature to determine the match. In case of unordered containment
> features the position should be ignored.
> 
> At least the feature-filter and measureDifferences should be fixed.

Hi Rolf,

I also have this problem, since the containment references are disordered, it always compare the wrong EObject. Any solution to fix this bug yet?

Regards,
Fangyi
Comment 2 Laurent Goubet CLA 2016-06-03 05:52:13 EDT
Sorry, this ticket kinda went under the radar.

It sounds like there is indeed a bug in there if we use the positions when checking for diffs in unordered references. We'll have to check the code, but the proximity-based matching is not on our priority list for now. Feel free to look at the issue if you have a reproduction case and some idea of what you expect. We'll gladly look at patches, and we'll be able to provide you with some pointers as to what to change if you have specific questions.